Refactoring TierABC into multiple Base Classes #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project in charge of heirarchy
Pleasing type checker by making default setter separate attribute.
created HomeTierBase
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.3.0-pre #127 +/- ##
=============================================
+ Coverage 57.58% 59.73% +2.14%
=============================================
Files 13 13
Lines 1252 1212 -40
=============================================
+ Hits 721 724 +3
+ Misses 531 488 -43 ☔ View full report in Codecov by Sentry. |
|
Compatibility will fail because there is no 0.3.x branch in jupyter_cassini currently... it will also fail once that is fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach is good because:
Using the BaseABC defines a low-level description of what's needed for a Tier.
But using the Notebook and Folder Base classes make getting to sensible implementations simple.
We do need to make sure users inherit from these base classes, rather than the defaults (which actually could be an argument for the HomeBase I provided in the other PR....)
Sensible defaults do make the code look confusing, but I think are actually helpful for users, defining all those things is a pain and a bit of magic is permissible I think.