-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Diem node upgrade restart #946
Merged
0o-de-lally
merged 26 commits into
0LNetworkCommunity:main
from
0o-de-lally:diem-node-upgrade-restart
Jan 19, 2022
Merged
[core] Diem node upgrade restart #946
0o-de-lally
merged 26 commits into
0LNetworkCommunity:main
from
0o-de-lally:diem-node-upgrade-restart
Jan 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include stdlib compiles
mortonbits
approved these changes
Jan 19, 2022
soaresa
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
dboreham
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Part II of the upgrade Move Cache reset. This includes only Rust changes for v5.0.11, which will be rolled out after the Move changes in v5.0.10 have propagated.
Here there are changes for the diem-node, specifically diem-vm, which will invoke a special Move function Upgrade::upgrade_reconfig, which triggers a new epoch event. This will create "phantom" epochs which last 2 rounds. Since the upgrade tick occurs on round 2, and a new epoch event (including incrementing the epoch number) is required to restart services, this epoch will be shorter.
However no accounting or payments occur in this epoch.