Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for duplicate blobbers #272

Merged
merged 9 commits into from
May 21, 2021
Merged

check for duplicate blobbers #272

merged 9 commits into from
May 21, 2021

Conversation

andrenerd
Copy link
Contributor

@andrenerd andrenerd commented May 12, 2021 •
edited

Prevent "double" registration for blobbers, checking Id/Url.

@andrenerd andrenerd requested a review from Sriep May 13, 2021 00:37
Sriep
Sriep suggested changes May 13, 2021
View reviewed changes
Copy link
Contributor

@Sriep Sriep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a unit test to prove the changes? Also add a description, even if it just links to the attached issues.

@andrenerd andrenerd linked an issue May 14, 2021 that may be closed by this pull request
Prevent duplicate registraton for blobber #253
Closed
@andrenerd andrenerd requested a review from Sriep May 20, 2021 23:00
@Sriep Sriep merged commit 42a5270 into master May 21, 2021
@Sriep Sriep deleted the fixes/prevent-duplicate-registraton-for-blobber-253 branch May 21, 2021 17:16
peterlimg added a commit that referenced this pull request May 28, 2021
@peterlimg
Merge branch 'vc-false-stuck' into fix/vc-true-stuck
6103afd 
* vc-false-stuck:
  Do not run computeState in goroutine in AddNotarizedBlock
  Fix issue in fetching blocks from sharders
  🐛 AddChallenge: randomise validators (#312)
  🔨 Immutable SmartContract objects (#313)
  check for duplicate blobbers (#272)
  🐛 Conversion Fix For Core
  🐛 Fix invalid type conversion
  🔨 New smart contract factroy (#295)
  Feature: httpclientutil and round tests (#288)
  Feature: add cache and common unit tests (#261)
  Update nginx.conf
  Update nginx.conf
  Feature: add datastore and ememorystore unit tests (#262)
  Feature: smartcontractinterface and tokenpool tests (#291)
  Feature: add encryption and logging unit tests (#264)
  Feature block unit tests (#248)
  🐛 Add mutex to mapIndex (#282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriep Sriep Sriep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent duplicate registraton for blobber
2 participants
@andrenerd @Sriep