Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutex to mapIndex #282

Merged
merged 1 commit into from
May 17, 2021
Merged

Add mutex to mapIndex #282

merged 1 commit into from
May 17, 2021

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented May 15, 2021

Issue #249.

Also removed confounding race error from code/go/0chain.net/sharder/blockdb/blockdb_test.go.

@Sriep Sriep linked an issue May 15, 2021 that may be closed by this pull request
@Sriep Sriep requested review from platsko and bbist May 15, 2021 17:16
Copy link
Contributor

@bbist bbist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Sriep Sriep merged commit 1c9e0c1 into master May 17, 2021
@Sriep Sriep deleted the map-index branch May 17, 2021 15:42
peterlimg added a commit that referenced this pull request May 28, 2021
* vc-false-stuck:
  Do not run computeState in goroutine in AddNotarizedBlock
  Fix issue in fetching blocks from sharders
  🐛 AddChallenge: randomise validators (#312)
  🔨 Immutable SmartContract objects (#313)
  check for duplicate blobbers (#272)
  🐛 Conversion Fix For Core
  🐛 Fix invalid type conversion
  🔨 New smart contract factroy (#295)
  Feature: httpclientutil and round tests (#288)
  Feature: add cache and common unit tests (#261)
  Update nginx.conf
  Update nginx.conf
  Feature: add datastore and ememorystore unit tests (#262)
  Feature: smartcontractinterface and tokenpool tests (#291)
  Feature: add encryption and logging unit tests (#264)
  Feature block unit tests (#248)
  🐛 Add mutex to mapIndex (#282)
peterlimg added a commit that referenced this pull request Jun 19, 2021
…bbist-vc-true-stuck

* 'bbist-vc-true-stuck' of github.com:/0chain/0chain: (117 commits)
  add logging for test: 2
  add logging for test
  link previous blocks beforehand
  remove path and description
  link blocks beforehand
  moved quickFixHostDuplication to separate testable function and added unit test
  fix method repetition
  reduce tolerance
  add vrfs_timeout_mismatch_tolerance
  fix test file name
  use normalized timeout count to generate bls message
  🐛 Add mutex to mapIndex (#282)
  fixed refrences to integration test files
  active view-change.fault-tolerance test cases
  view-change.fault-tolerance test cases
  Merge branch 'fix/vc-true-stuck' into bbist-vc-true-stuck
  fix incorrect sharders selection while running simplenodes reduce
  add node simplenodes reduce unit test
  Fix goroutine leak on SetupSC
  Move http request error to N2n logger
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race error: Protect blockdb.mapIndex.
2 participants