New smart contract factroy #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sriep
changed the title
Sriep
changed the title
peterlimg
added a commit
that referenced
this pull request
May 28, 2021
* vc-false-stuck: Do not run computeState in goroutine in AddNotarizedBlock Fix issue in fetching blocks from sharders 🐛 AddChallenge: randomise validators (#312) 🔨 Immutable SmartContract objects (#313) check for duplicate blobbers (#272) 🐛 Conversion Fix For Core 🐛 Fix invalid type conversion 🔨 New smart contract factroy (#295) Feature: httpclientutil and round tests (#288) Feature: add cache and common unit tests (#261) Update nginx.conf Update nginx.conf Feature: add datastore and ememorystore unit tests (#262) Feature: smartcontractinterface and tokenpool tests (#291) Feature: add encryption and logging unit tests (#264) Feature block unit tests (#248) 🐛 Add mutex to mapIndex (#282)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #260
Currently, there is only one smart contract object for each of the smart contracts. Each time a new smart contract is requested, its contents are copied onto itself. This copying is not properly protected against concurrent access.
This PR creates a different instance of a smart contract each time one is called. A new smart contract factory object is built to create them. This extra effort of a factory interface is needed to prevent against import cycles.