Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddChallenge: randomise validators #312

Merged
merged 7 commits into from
May 23, 2021
Merged

AddChallenge: randomise validators #312

merged 7 commits into from
May 23, 2021

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented May 21, 2021 •
edited

  1. Randomise validators selected for a challenge; issue Challenge creation: Select validators randomly #234.
  2. Unit test for addChallenge to check these changes.
  3. Removed dead comments.
  4. Lint fixes:
smartcontract/storagesc/challenge.go:32:2: ineffectual assignment to idx (ineffassign)
	idx := -1
	^
smartcontract/storagesc/challenge_test.go:418:2: assign: self-assignment of blobber to blobber (govet)
	blobber = blobber
	^
smartcontract/storagesc/challenge_test.go:416:2: SA4006: this value of `blobber` is never used (staticcheck)
	blobber, err := ssc.getStakePool(blobberId, ctx)
	^
  1. Reduce the lint limit.

@Sriep Sriep linked an issue May 21, 2021 that may be closed by this pull request
Challenge creation: Select validators randomly #234
Closed
@Sriep Sriep requested review from bbist and andrenerd May 21, 2021 14:28
bbist
bbist reviewed May 23, 2021
View reviewed changes
Copy link
Contributor

@bbist bbist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

code/go/0chain.net/smartcontract/storagesc/challenge_test.go Outdated Show resolved Hide resolved
Sriep added 3 commits May 23, 2021 10:03
@Sriep
Merge branch 'master' of https://github.com/0chain/0chain into random…
91fe0bd 
…-validators

� Conflicts:
�	code/go/0chain.net/smartcontract/storagesc/sc.go
@Sriep
👌 spelling plus refactor
2af964c
@Sriep
👕 lint fixes
af10789
@Sriep Sriep merged commit f84a3d8 into master May 23, 2021
@Sriep Sriep deleted the random-validators branch May 23, 2021 10:07
peterlimg added a commit that referenced this pull request May 28, 2021
@peterlimg
Merge branch 'vc-false-stuck' into fix/vc-true-stuck
6103afd 
* vc-false-stuck:
  Do not run computeState in goroutine in AddNotarizedBlock
  Fix issue in fetching blocks from sharders
  🐛 AddChallenge: randomise validators (#312)
  🔨 Immutable SmartContract objects (#313)
  check for duplicate blobbers (#272)
  🐛 Conversion Fix For Core
  🐛 Fix invalid type conversion
  🔨 New smart contract factroy (#295)
  Feature: httpclientutil and round tests (#288)
  Feature: add cache and common unit tests (#261)
  Update nginx.conf
  Update nginx.conf
  Feature: add datastore and ememorystore unit tests (#262)
  Feature: smartcontractinterface and tokenpool tests (#291)
  Feature: add encryption and logging unit tests (#264)
  Feature block unit tests (#248)
  🐛 Add mutex to mapIndex (#282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrenerd andrenerd andrenerd left review comments

@bbist bbist bbist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Challenge creation: Select validators randomly
3 participants
@Sriep @andrenerd @bbist