Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel upload #1374

Merged
merged 47 commits into from
Feb 22, 2024
Merged

Parallel upload #1374

merged 47 commits into from
Feb 22, 2024

Conversation

Hitenjain14
Copy link
Member

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

Attention: 192 lines in your changes are missing coverage. Please review.

Comparison is base (1d81b05) 14.40% compared to head (d9f2fbc) 14.95%.

Files Patch % Lines
...go/0chain.net/blobbercore/allocation/connection.go 9.72% 63 Missing and 2 partials ⚠️
...ode/go/0chain.net/blobbercore/filestore/storage.go 26.82% 28 Missing and 2 partials ⚠️
...ain.net/blobbercore/handler/file_command_update.go 0.00% 25 Missing ⚠️
...chain.net/blobbercore/filestore/tree_validation.go 63.93% 18 Missing and 4 partials ⚠️
...et/blobbercore/handler/object_operation_handler.go 25.00% 15 Missing and 3 partials ⚠️
...ain.net/blobbercore/handler/file_command_upload.go 46.66% 13 Missing and 3 partials ⚠️
...ain.net/blobbercore/allocation/allocationchange.go 0.00% 10 Missing ⚠️
code/go/0chain.net/core/common/handler.go 50.00% 3 Missing ⚠️
...ain.net/blobbercore/handler/file_command_delete.go 0.00% 2 Missing ⚠️
code/go/0chain.net/blobbercore/handler/worker.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           sprint-1.13    #1374      +/-   ##
===============================================
+ Coverage        14.40%   14.95%   +0.54%     
===============================================
  Files              177      178       +1     
  Lines            19859    19854       -5     
===============================================
+ Hits              2861     2969     +108     
+ Misses           16642    16520     -122     
- Partials           356      365       +9     
Flag Coverage Δ
Unit-Tests 14.95% <42.68%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber feat/parallel-upload
authorizer
0box
0dns

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli
0chain
blobber feat/parallel-upload
authorizer
0box
0dns

@Hitenjain14 Hitenjain14 marked this pull request as ready for review January 23, 2024 16:32
@Hitenjain14 Hitenjain14 marked this pull request as draft January 23, 2024 16:32
@Hitenjain14 Hitenjain14 marked this pull request as ready for review January 30, 2024 20:46
@Hitenjain14 Hitenjain14 changed the base branch from sprint-1.12 to sprint-1.13 February 12, 2024 16:58
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit c8f4be5 into sprint-1.13 Feb 22, 2024
7 checks passed
@dabasov dabasov deleted the feat/parallel-upload branch February 22, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants