Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix caching for fees table #1113

Merged
merged 15 commits into from
Jul 22, 2023
Merged

fix caching for fees table #1113

merged 15 commits into from
Jul 22, 2023

Conversation

boddumanohar
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@boddumanohar boddumanohar linked an issue Jul 13, 2023 that may be closed by this pull request
Transaction fee cache issue in wasm #1112
Closed
dabasov
dabasov requested changes Jul 14, 2023
View reviewed changes
core/transaction/entity.go Outdated Show resolved Hide resolved
@dabasov dabasov changed the base branch from sprint-july-2 to sprint-july-3 July 17, 2023 09:23
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests
gosdk fix-fees
zboxcli
zwalletcli
0chain
blobber
authorizer
0box
0dns

@dabasov dabasov merged commit e80d317 into sprint-july-3 Jul 22, 2023
11 checks passed
@dabasov dabasov deleted the fix-fees branch July 22, 2023 09:20
dabasov
dabasov reviewed Jul 22, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

YarikRevich pushed a commit that referenced this pull request Jul 22, 2023
@boddumanohar @dabasov @YarikRevich
fix caching for fees table (#1113)
452812b 
* fix caching for fees table

* handle error

* conver to lowercase

* add logs

* use println logs

* use zboxcore/logger

* use toAddress

* revert logging

---------

Co-authored-by: Yury <yuderbasov@gmail.com>
cnlangzi pushed a commit that referenced this pull request Jul 28, 2023
@boddumanohar @dabasov @cnlangzi
fix caching for fees table (#1113)
62b25f3 
* fix caching for fees table

* handle error

* conver to lowercase

* add logs

* use println logs

* use zboxcore/logger

* use toAddress

* revert logging

---------

Co-authored-by: Yury <yuderbasov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov requested changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction fee cache issue in wasm
3 participants
@boddumanohar @service-0chain @dabasov