Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React Components #125

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Add React Components #125

merged 2 commits into from
Oct 25, 2022

Conversation

0exbot
Copy link

@0exbot 0exbot commented Oct 25, 2022

Pull request from @brillout.

My first curated list 😊 ✨

https://github.com/brillout/awesome-react-components

React Components, categorized

@0exbot
Copy link
Author

0exbot commented Oct 25, 2022

@-sindresorhus on 2016-06-25 09:51 says: This is already covered by https://github.com/enaqx/awesome-react#components though. Maybe you could collaborate with them somehow?

// @-browniefed @-enaqx

@0exbot
Copy link
Author

0exbot commented Oct 25, 2022

@-brillout on 2016-06-25 10:35 says: Collaboration would be great. There are so many react components out there. It's astonishing.

I think that the awesome-react-components list should not include learning material. I would not merge both lists. They serve two distinct use cases;

  • If I want to learn about React then I go to awesome-react
  • If I write code and I need a specific component then I go to awesome-react-components

I like the idea of keeping things small, "do one thing and do it well".

Although, there are some components that are innovative and stumbling upon them represents a learning experience. That is actually what the creative section is about, https://github.com/brillout/awesome-react-components#creative-things. For example, when I first stumbled upon react-virtualized, I learned about the idea of lazy loaded tables. Therefore the creative things section would make sense in awesome-react.

@-browniefed @-enaqx what do you think?

@-sindresorhus thanks for putting us in touch!

@0exbot
Copy link
Author

0exbot commented Oct 25, 2022

@-browniefed on 2016-06-26 01:50 says: No opinion here :), there are a lot of resources out there like react.rocks, js.coach, etc that list both just components, resources, or a mix a both.
The more the merrier.

@0exbot
Copy link
Author

0exbot commented Oct 25, 2022

@-hatzopoulos on 2016-06-27 17:11 says: Nice list @-brillout !

has been around for at least 20 days,

Looking at the commit history, it would seem like this has only been up on github for 3 days.

is not a duplicate

Since the other list, https://github.com/enaqx/awesome-react#components contains components I would consider this a duplicate because eventually the components list will just be a variation of the of the other.

Collaboration would be great

Yes! It would be really nice if your efforts were combined into that already awesome list of react stuff. The way you have categorized the components is great. It would be awesome if that categorization found its way into the awesome-react list.

Whether I am learning react for the first time or a veteran using the list as a toolbox resource, having one one list is great for both cases.

Alternatively perhaps the awesome-react list can remove the components list all together and just link to your awesome-react-components list, but for that it would be nice if you merged any missing components into your list.

@0exbot
Copy link
Author

0exbot commented Oct 25, 2022

@-browniefed on 2016-06-27 17:54 says: If you're interested we can just add you as a maintainer and you can help out with the awesome-react repo if that interests you at all.

@0exbot
Copy link
Author

0exbot commented Oct 25, 2022

@-brillout on 2016-06-27 21:58 says: @-hatzopoulos

Nice list

Thanks :)

this has only been up on github for 3 days.

Yes, it's on GitHub since 3 days only. I've started creating it ~2 months ago though.
I've interpreted "has been around for at least 20 days" as "has been alive for at least 20 days". If it means "has been public for at least 20 days" then I'll uncheck the checkbox and close the PR.

The way you have categorized the components is great

I see categorization to be super important.
Actually, I think that sections that have more than ~15 items should systematically be broken down into sub-sections.
And I could see that to be a meaningful rule for creating Awesome Lists.
@-sindresorhus what do you think?

It would be really nice if your efforts were combined into that already awesome list of react stuff

I'd love to "join forces".

Whether I am learning react for the first time or a veteran using the list as a toolbox resource, having one one list is great for both cases

I struggle with the idea of having only one React list that includes both learning material and components.
Personally, I am more interested in the components part and less in the learning material part.
I can see other people to be also interested in only either one.
Having awesome-react and awesome-react-components would allow one to watch either one or both.
I'm considering implementing automated manipulations on the list (show number of GitHub stars for every component, sort components after repository creation date and GitHub stars, etc.). In that context it would feel cluttered to apply automation on only a subset of a huge list.

would be nice if you merged any missing components into your list.

Yes. Although I consider some of the components to be low quality and I would discard them.


@-browniefed

If you're interested we can just add you as a maintainer

Thanks and yes I'd be up for that!
Since we would be 3 maintainers, maybe we should create a GitHub organization then?

@0exbot
Copy link
Author

0exbot commented Oct 25, 2022

@-sindresorhus on 2016-07-04 22:53 says:

Actually, I think that sections that have more than ~15 items should systematically be broken down into sub-sections. And I could see that to be a meaningful rule for creating Awesome Lists. @-sindresorhus what do you think?

Hard to find a number in scenarios. Common sense should work here.

I'd love to "join forces".

👌

@akvadrako akvadrako merged commit 5a0a83f into main Oct 25, 2022
@akvadrako akvadrako deleted the pull/698 branch October 25, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants