Simplify GUI build using dune's new plugin support #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids using OCaml code in the dune file. It also makes it easier to use 0install as a vendored library without it printing warnings about GTK not being built.
|
Looks like this is needed for Fedora 32, which is failing on |
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Aug 19, 2022
CHANGES: Changes: - Add support for ARM64 (Bastian Eicher). - Add `+` to list of allowed characters in "extract" (Bastian Eicher, 0install/0install#185). Bug fixes: - Don't abort if chmod of launcher directory fails. We try to make the directory read-only, but this isn't very important. It can sometimes fail if running inside a sandbox that prevents modifications to the filesystem. - Handle implementations that directly conflict with themselves (0install/0install#180). - Improve SIGPIPE handling (0install/0install#162). Disable the SIGPIPE signal, so that we handle it as an exception instead, not by killing the process. Updates for upstream changes: - Make compatible with Yojson `json` type deprecation (Marek Kubica). Yojson 2.0 removes the `json` type, so this code switches to using `t`. - Replace uses of deprecated `Stdlib.Stream` and `Lwt_unix.yield`. - Fix new compiler warnings from OCaml 4.12 and 4.13. - Update .NET Framework detection logic (Bastian Eicher, 0install/0install#178). - Simplify GUI build using dune's new plugin support (0install/0install#161). - Move feed to apps.0install.net (Bastian Eicher).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Aug 19, 2022
CHANGES: Changes: - Add support for ARM64 (Bastian Eicher). - Add `+` to list of allowed characters in "extract" (Bastian Eicher, 0install/0install#185). Bug fixes: - Don't abort if chmod of launcher directory fails. We try to make the directory read-only, but this isn't very important. It can sometimes fail if running inside a sandbox that prevents modifications to the filesystem. - Handle implementations that directly conflict with themselves (0install/0install#180). - Improve SIGPIPE handling (0install/0install#162). Disable the SIGPIPE signal, so that we handle it as an exception instead, not by killing the process. Updates for upstream changes: - Make compatible with Yojson `json` type deprecation (Marek Kubica). Yojson 2.0 removes the `json` type, so this code switches to using `t`. - Replace uses of deprecated `Stdlib.Stream` and `Lwt_unix.yield`. - Fix new compiler warnings from OCaml 4.12 and 4.13. - Update .NET Framework detection logic (Bastian Eicher, 0install/0install#178). - Simplify GUI build using dune's new plugin support (0install/0install#161). - Move feed to apps.0install.net (Bastian Eicher).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Aug 19, 2022
CHANGES: Changes: - Add support for ARM64 (Bastian Eicher). - Add `+` to list of allowed characters in "extract" (Bastian Eicher, 0install/0install#185). Bug fixes: - Don't abort if chmod of launcher directory fails. We try to make the directory read-only, but this isn't very important. It can sometimes fail if running inside a sandbox that prevents modifications to the filesystem. - Handle implementations that directly conflict with themselves (0install/0install#180). - Improve SIGPIPE handling (0install/0install#162). Disable the SIGPIPE signal, so that we handle it as an exception instead, not by killing the process. Updates for upstream changes: - Make compatible with Yojson `json` type deprecation (Marek Kubica). Yojson 2.0 removes the `json` type, so this code switches to using `t`. - Replace uses of deprecated `Stdlib.Stream` and `Lwt_unix.yield`. - Fix new compiler warnings from OCaml 4.12 and 4.13. - Update .NET Framework detection logic (Bastian Eicher, 0install/0install#178). - Simplify GUI build using dune's new plugin support (0install/0install#161). - Move feed to apps.0install.net (Bastian Eicher).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: can't be merged until Debian has dune >= 2.5.
https://tracker.debian.org/pkg/ocaml-dune