Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a json file to be ready to use packagist #1

Closed
wants to merge 1 commit into from
Closed

adding a json file to be ready to use packagist #1

wants to merge 1 commit into from

Conversation

Grummfy
Copy link
Contributor

@Grummfy Grummfy commented Jan 27, 2014

Hello,
I think it could be intresting to use packagist to expose a litle bit more this library, so I add the basic of a composer file.

Afte merging, you add your package trought the website of packagist https://packagist.org

@vaab
Copy link
Member

vaab commented Jan 27, 2014

Ok, thanks ! Let me a few moment to check what is all this ;) ... (I'm not much involved in PHP development nowadays ;) ). I see that I need to get the licence right, and I just need to gather enough information to make a full test of this myself.
As I'm a little busy right now, this may take one or two days. Hope this is ok with you.

@Grummfy
Copy link
Contributor Author

Grummfy commented Jan 27, 2014

No problem.
You should retag this reprository right after to include in a tagged version the composer.json.

For information packagist is a central repository for library and others.

vaab added a commit that referenced this pull request Jan 28, 2014
@vaab
Copy link
Member

vaab commented Jan 28, 2014

I did take a look to composer and made a full test. This made me realize that I hadn't any namespace and thus no class auto-loading feature. I added these features.

To test all this I moved the index.php (which was the example code) towards a sample-project directory with it's own composer.json. This allows to quickly build and test php-oe-json.

You can check the code/commits on the branch 'pr1' I made: https://github.com/0k/php-oe-json/tree/pr1

If this is okay with you, I'll push this branch to master and will declare this package in Packagist, and tag version 0.0.2.

@ghost ghost assigned vaab Jan 28, 2014
@Grummfy
Copy link
Contributor Author

Grummfy commented Jan 28, 2014

Seems OK, just change the example in readme parth to include the namespace.

Thanks

@vaab vaab closed this in 5ea6bc9 Jan 28, 2014
vaab added a commit that referenced this pull request Jan 28, 2014
@vaab
Copy link
Member

vaab commented Jan 28, 2014

It's all done. Thanks for your review and your interest ! Have fun !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants