-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: Increase support of harder to detect gql.tada
API usage patterns
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f796266 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
commented
Apr 26, 2024
JoviDeCroock
approved these changes
Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Marking this as a
minor
since we already have minor changes queued up and some of the API signatures have changed slightly.Summary
This aims to reduce the amount of separate
templates.has
based checks and introduce a new check that can also detectgql.tada
via theTypeChecker
as a fallback if the name (or expression) ofgraphql()
calls is non-standard.Set of changes
checks.ts
for all predicatesgraphql()
calls by checking!!graphql.scalar
and!!graphql.persisted
via the typ e checkergraphql
itself is not an identifier (any expression)graphql
is renamed (more relevant now due to multi-schema support)graphql.persisted()
calls with the above logictemplates.has
into few reusable functionisCallExpression
was truthyNoSubstitutionTemplateLiteral
toStringLiteralLike
graphql('...')
andgraphql("...")
will work nowTypeChecker
based approach here forarguments[0]
orarguments[1]
yet, but this could lead to some refactors which might slim down the codebasegetAllFragments
from expanding to check for fragments via declarations (graphql-code-generator
code branch) even ifgql.tada
is active with newisTadaGraphQLCall
checkgraphql()
fragments array literal argumentas const
PropertyAccessExpression
s