Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donor Directed Accounts Liquidation #14

Merged
merged 11 commits into from
Apr 14, 2023

Conversation

0o-de-lally
Copy link
Owner

@0o-de-lally 0o-de-lally commented Apr 14, 2023

Donor directed wallet liquidation case was incomplete.

  • Donor directed wallets can be liquidated by donors with ParticipationVote like Veto of transactions.
  • In default case the funds return to the donor wallets
  • In the community wallet case, the funds go to TransactionFee so it follows the usual burn/recycle governance.
  • The VM needs to execute this on the epoch boundary
  • Tx tests for whole flow of liquidation

@0o-de-lally 0o-de-lally changed the title V6 0d patch donor directed Donor Directed Accounts Liquidation Apr 14, 2023
commit ab1da1d
Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
Date:   Fri Apr 14 17:36:50 2023 -0400

    Hard Fork Migrations (#13)

    * add tower state migration

    * migrate community wallet list

    * ancestry struct resources

    * use coin split in genesis migration

    * migrate ancestry and receipts

    * migrates diemaccount cumulative tracker

    * migrate slow wallet

    * patch community wallet migrate

    * epoch migration stub.

    * slow wallet unlock with coin split factor

    * cleanup names
@0o-de-lally 0o-de-lally merged commit 8a9c874 into v6-0d-rc.1 Apr 14, 2023
0o-de-lally added a commit that referenced this pull request Jul 5, 2023
* refactor donation tracking to also keep a struct of the addresses in one place.

* refactor the liquidation of donor directed wallets, in including community wallet case

* patch community wallet veto test

* fix nasty oversight with double counting cumulative deposits.

* community pro_rata calculation and test

* refactor vm_make_payment_no_limit to account for withdraw capabilities being delegated in multisig wallets.

* donor directed wallet liquidation flow tested.

* clean print

* all tests passing.

* Squashed commit of the following:

commit ddac86e
Author: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
Date:   Fri Apr 14 17:36:50 2023 -0400

    Hard Fork Migrations (#13)

    * add tower state migration

    * migrate community wallet list

    * ancestry struct resources

    * use coin split in genesis migration

    * migrate ancestry and receipts

    * migrates diemaccount cumulative tracker

    * migrate slow wallet

    * patch community wallet migrate

    * epoch migration stub.

    * slow wallet unlock with coin split factor

    * cleanup names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant