-
Notifications
You must be signed in to change notification settings - Fork 9
Should I submit a PR? or should I fork? #12
Comments
@upleveled is also interested in contributing to an @ProchaLu is investigating some alternatives now, including:
It seems that some of our goals are aligned here, maybe it would make sense to work together on this? |
I'm down to combine our efforts. From your list, I'd start with # 2, just because I'm familiar with MDXP. And this will also include # 1, because I'm all in with updating to MDX 2.0 What should the next steps be? I'm starting to create a MDXP branch with the changes. My original plan was to propose a huge Pull Request. But forking the project with you guys would be a lot of fun! Let's make this happen! I'm stoked! |
Nice, sounds like it could be a good collaboration 👍 Next steps seem like (to me): A) @ProchaLu is going to start working on this again in January, so he can continue with the work he was doing investigating B) In the meantime, if you want help testing the changes that you're doing to MDXP, then I may be able to take a look during the next weeks - for your plan above, you may also want to consider Shiki as an alternative to Prism C) Maybe starting with a PR here in this repo would give @0phoff one last chance to accept updates to MDXP under his stewardship - also, it's fine to review and test the changes in a PR here too D) And then if there's no movement here or if @0phoff decides that they do not want to maintain this project anymore, we can think about forking and future ownership |
First, an update on my work (I will post a reply to @karlhorky in a separate message): I tried very hard to update all dependencies of MDPX. The first half was straightforward and simple (React, Lerna, Chalk, etc). But I got to some major roadblocks trying to update the last few dependencies. The MDXP codebase is based on MDX-Deck, a Gatsby 2.0 project. MDX-Deck hasn't been updated in the last few years, and cannot run on the newer versions of Gatsby (neither 3.0, 4.0 or 5.0). When MDXP was created, the team started from MDX-Deck, striped away Gatsby, and replaced it with WebPack. The problem I face is that both MDX-Deck and MDXP are heavily dependant on a CSS-in-JS engine called These changes are so extensive that I feel that we should drop This means that one would have to rewrite a lot of the existing code base. That is a lot to do alone. So unless there is interest from the community to help me, I prefer helping @karlhorky and @ProchaLu with their project. |
I'm now ready to give him a hand. I'll start to get a look at
I now believe that MDXP dependency on
Thanks for the tip!
After my analysis, I feel that there's going to be a lot of rewriting of the MDXP codebase. And sorta feel that that |
Interesting, too bad about this. How many versions can you upgrade without it breaking? Some seemingly relevant breaking changes of APIs I see are: |
Sure, sounds good. @ProchaLu's plan was to look at the PR below and try to reimplement as a new PR to the This work will be useful regardless of what solution we have in the end (MDXP, |
We have not invested effort in getting it working with Gatsby v5 yet, because we are trying to move off of Gatsby. But theoretically upgrading to Gatsby v5 may not be too much work, after following my guides above. This would be a part of my option 4 "Fork |
Hi @EricCote, I hope you still want to collaborate with us. To make communication faster, I would reach out on Twitter, and we can discuss future plans. I would start to continue with the work I was doing, investigating |
As you probably have guessed, I do not have the time to maintain this project anymore. Personally, I moved over to using slidev, which is a very similar project, only that it is implemented with Vue. It has a bigger team behind it and will thus have more frequent updates. As with any open-source projects, feel free to fork it and adapt it to your needs ! FYI |
Seems like Spectacle is the most modern, maintained option for React + MDX slide decks As of |
Oh looks like @cpojer just created a minimalist slide deck framework called ReMDX based on a lean fork of Spectacle 👀🔥 |
@0phoff said over 20 months ago:
I don't have a lot of time to work on MDXP right now, but once I do, I will probably go through the entire codebase and try to update each of the packages to their newest versions.
Originally posted by @0phoff in #5 (comment)
After 20 months, I wonder if anything will move?
I want to repair a few of those issues for the courses I do. I want to publish a few slide decks for React Academy (https://www.reactacademy.live/live). So I'll be doing a major PR.
Here's I what I want to do:
Anything else?
The text was updated successfully, but these errors were encountered: