Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to Korean #35

Merged
merged 44 commits into from
Aug 20, 2024
Merged

Translate to Korean #35

merged 44 commits into from
Aug 20, 2024

Conversation

maldron0309
Copy link
Contributor

@maldron0309 maldron0309 commented Aug 20, 2024

Translate to Korean

Overview

This PR translates the entire "Say Hello to x86_64 Assembly" series and additional files into Korean. To preserve the original tone as much as possible, technical terms are kept in their original form or included in parentheses. Some links (e.g., Wikipedia) have been redirected to their Korean versions.

Translated Content

  • Part 1 ~ Part 8
  • CONTRIBUTING
  • CODE_OF_CONDUCT
  • README
  • SECURITY

Self-Check Checklist

  • Verified the accuracy of the entire translation.
  • Ensured consistency and clarity across all parts.
  • Checked document formatting and readability.
  • Confirmed that the translated code and explanations match the original text.

How to Test

The translated documents are located in the ko_doc folder. The post folder contains the assembly tutorial documents.

Additional Information

The original title is "Say Hello to x86_64 Assembly." Since a direct translation into Korean would sound unnatural, I have paraphrased it.

Additionally, in the final sections of Parts 1 through 8, there is a "Translator's Note" section that includes my personal reflections on learning assembly. If this was not intended or is unsuitable, I will remove it.

Feedback

I have aimed to convey the original text as accurately as possible, but there may be grammatical errors and readability issues. If any are found, please let me know, and I will make the necessary corrections and resubmit the PR as soon as possible :)

Thank you.

@klaudiagrz
Copy link
Collaborator

Hello @maldron0309 ! 👋

Thank you for your contribution, you did a great job!

Just one suggestion regarding the source for the Korean translation. Could you either:

  • Put the content into the translations/ko directory and adjust the links in README, OR
  • Keep the Korean content on your fork and remove ko_doc from PR. You provide links to your fork in README anyway and that's also how other translations are maintained.

We are okay to keep the content in this repo, however, as we do not know Korean, it would be difficult for us to maintain it. Please consider these options.

@maldron0309
Copy link
Contributor Author

Hello👋
Thank you for your feedback and suggestions. As you mentioned, I realized that managing the Korean documents might not be easy for you, so I decided to manage them in my fork. I've deleted the ko_doc directory and pushed the changes. Thank you for your feedback!!!

@klaudiagrz
Copy link
Collaborator

klaudiagrz commented Aug 20, 2024

@maldron0309 Thanks a lot! Merging the PR 🙂
Feel free to add yourself to CONTRIBUTORS.md.

@klaudiagrz klaudiagrz merged commit d2cb168 into 0xAX:master Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants