Add timeout to proof generation, and enable cancelling proofs #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former is necessary, as sometimes proof generation will run forever (I believe this is a snag in snarkjs), while the later is just good practice, right now cancelling has no effect but to dismiss a modal that will come back later.
Note that this is the only time we currently are able (i.e. that we implemented) to meaningfully cancel an action. Cancelling at other times (e.g. when sending transactions) will simply cause the modal to be dismissed and to come back later (or the action to complete). We need to implement this too.