Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update linters #40

Merged
merged 18 commits into from
Nov 10, 2022
Merged

update linters #40

merged 18 commits into from
Nov 10, 2022

Conversation

JekaMas
Copy link
Contributor

@JekaMas JekaMas commented Nov 4, 2022

Description

Update linters to the newest version and actualize the list of the linters

to try all linters without respect to the latest changes use make lint-all - as far as I see this gives quite strict code style, that might need be adopted, although most of the warnings should be fixed in a separate task.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have added sufficient documentation in code

@JekaMas JekaMas added the feature New functionality label Nov 4, 2022
@JekaMas JekaMas self-assigned this Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #40 (e350dc6) into main (ee4d8a0) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head e350dc6 differs from pull request most recent head 8d231b5. Consider uploading reports for the commit 8d231b5 to get more accurate results

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   95.51%   95.35%   -0.16%     
==========================================
  Files           6        6              
  Lines        1292     1292              
==========================================
- Hits         1234     1232       -2     
- Misses         42       43       +1     
- Partials       16       17       +1     
Impacted Files Coverage Δ
core/ibft.go 94.81% <0.00%> (-0.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

.github/workflows/lint.yml Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
Co-authored-by: Victor Castell <victor@victorcastell.com>
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

.golangci.yml Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
@JekaMas JekaMas merged commit 12435ef into main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants