Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename baseFee json field to baseFeePerGas #1538

Merged
merged 1 commit into from
May 24, 2023
Merged

Rename baseFee json field to baseFeePerGas #1538

merged 1 commit into from
May 24, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented May 23, 2023 •
edited

Description

Rename baseFee json field to baseFeePerGas in Header model

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this May 23, 2023
@begmaroman begmaroman merged commit e859acf into develop May 24, 2023
9 checks passed
@begmaroman begmaroman deleted the fix/rename-base-fee-json-field branch May 24, 2023 10:35
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@igorcrevar igorcrevar Awaiting requested review from igorcrevar

Assignees

@begmaroman begmaroman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@begmaroman @vcastellm @Stefan-Ethernal @goran-ethernal