Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print child token address as part of deposit commands #1616

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Print child token address as part of deposit commands #1616

merged 4 commits into from
Jun 14, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Jun 13, 2023 •
edited
Loading

Description

This PR introduces outputting of the child token address in the deposit commands.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal requested a review from a team June 13, 2023 19:28
@Stefan-Ethernal Stefan-Ethernal self-assigned this Jun 13, 2023
@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Jun 13, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-694-print-child-token-address-as-part-of-deposit-commands branch from 8b441bd to 25ba036 Compare June 13, 2023 19:36
@Stefan-Ethernal Stefan-Ethernal merged commit 902bd37 into develop Jun 14, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-694-print-child-token-address-as-part-of-deposit-commands branch June 14, 2023 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@stana-miric stana-miric stana-miric approved these changes

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stefan-Ethernal @stana-miric @goran-ethernal @igorcrevar