Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TxPool] Fix double nonce in promoted #739

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

dbrajovic
Copy link
Contributor

@dbrajovic dbrajovic commented Sep 16, 2022

Fix EDGE-813

Description

This PR fixes the issue of transactions sharing nonce ending up in promoted queue of an account.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Kourin1996 Kourin1996 marked this pull request as ready for review September 16, 2022 13:48
@Kourin1996 Kourin1996 added the bug fix Functionality that fixes a bug label Sep 16, 2022
txpool/account.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/0.5.1@06d3f72). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/0.5.1     #739   +/-   ##
================================================
  Coverage                 ?   49.07%           
================================================
  Files                    ?      112           
  Lines                    ?    15535           
  Branches                 ?        0           
================================================
  Hits                     ?     7624           
  Misses                   ?     7274           
  Partials                 ?      637           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor Author

@dbrajovic dbrajovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve this (since I opened the PR).

LGTM 👍

Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good 💯

Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kourin1996 Kourin1996 merged commit ff0d3d3 into release/0.5.1 Sep 22, 2022
@Kourin1996 Kourin1996 deleted the fix/txpool-double-tx-in-promoted branch September 22, 2022 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants