Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason,
debug/vars
URL endpoint on thejson-rpc
http API is enabled by default whenDefaultServeMux
is used, even thoughexpvar
package is not imported anywhere.This presents a potential security issue and needs to be disabled by using
NewServeMux
function, instead ofDefaultServeMux
.Changes include
Checklist
Testing
Manual tests
Compile binary from this branch and query
debug/vars
GET endpoint on JSON-RPC API. For example:localhost:8545/debug/vars
. You should get the default GET output.Additional comments
Fixes EDGE-856