Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/counters and comments #227

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Feature/counters and comments #227

merged 1 commit into from
Jan 13, 2023

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • adds safe range of 5% for zk-counters

@cla-bot cla-bot bot added the cla-signed label Jan 13, 2023
@krlosMata krlosMata changed the base branch from main to develop January 13, 2023 15:59
@krlosMata krlosMata marked this pull request as draft January 13, 2023 15:59
ignasirv
ignasirv approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata changed the title Feature/counters and opt Feature/counters and comments Jan 13, 2023
@krlosMata krlosMata marked this pull request as ready for review January 13, 2023 16:35
@krlosMata krlosMata merged commit af786a8 into develop Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasirv ignasirv ignasirv approved these changes

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krlosMata @ignasirv