-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset preservation implementation #198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisitano
force-pushed
the
frisitano-asset-preservation
branch
from
August 15, 2023 20:19
0025b2e
to
6914aa9
Compare
frisitano
force-pushed
the
frisitano-asset-preservation
branch
from
August 15, 2023 20:28
6914aa9
to
7733a0c
Compare
frisitano
force-pushed
the
frisitano-vault-masm
branch
3 times, most recently
from
August 17, 2023 04:52
896835d
to
665acb0
Compare
frisitano
force-pushed
the
frisitano-asset-preservation
branch
5 times, most recently
from
August 17, 2023 05:33
e6717cc
to
004ba57
Compare
frisitano
force-pushed
the
frisitano-vault-masm
branch
from
August 17, 2023 11:52
665acb0
to
9d7e866
Compare
frisitano
force-pushed
the
frisitano-asset-preservation
branch
2 times, most recently
from
August 17, 2023 13:00
a6c39ce
to
7e1cccb
Compare
frisitano
commented
Aug 17, 2023
frisitano
force-pushed
the
frisitano-asset-preservation
branch
2 times, most recently
from
August 18, 2023 09:45
6bbc551
to
d41f343
Compare
bobbinth
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a few comments inline. The ones that are not straight-forward, could be addressed in future PRs.
frisitano
force-pushed
the
frisitano-asset-preservation
branch
from
August 20, 2023 09:30
d41f343
to
8639b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements asset preservation. It currently has a separate loop to add assets to the input vault and output vault. I propose we create an issue to optimise this in the future.