Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset preservation implementation #198

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

frisitano
Copy link
Contributor

@frisitano frisitano commented Aug 15, 2023

This PR implements asset preservation. It currently has a separate loop to add assets to the input vault and output vault. I propose we create an issue to optimise this in the future.

@frisitano frisitano force-pushed the frisitano-vault-masm branch 3 times, most recently from 896835d to 665acb0 Compare August 17, 2023 04:52
@frisitano frisitano force-pushed the frisitano-asset-preservation branch 5 times, most recently from e6717cc to 004ba57 Compare August 17, 2023 05:33
Base automatically changed from frisitano-vault-masm to main August 17, 2023 12:00
@frisitano frisitano force-pushed the frisitano-asset-preservation branch 2 times, most recently from a6c39ce to 7e1cccb Compare August 17, 2023 13:00
@frisitano frisitano force-pushed the frisitano-asset-preservation branch 2 times, most recently from 6bbc551 to d41f343 Compare August 18, 2023 09:45
@frisitano frisitano marked this pull request as ready for review August 18, 2023 09:56
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few comments inline. The ones that are not straight-forward, could be addressed in future PRs.

miden-lib/asm/sat/internal/note_setup.masm Outdated Show resolved Hide resolved
miden-lib/asm/sat/internal/account_vault.masm Outdated Show resolved Hide resolved
miden-lib/asm/sat/internal/account_vault.masm Outdated Show resolved Hide resolved
miden-lib/asm/sat/internal/account_vault.masm Outdated Show resolved Hide resolved
miden-lib/asm/sat/internal/layout.masm Show resolved Hide resolved
objects/src/transaction/mod.rs Outdated Show resolved Hide resolved
@frisitano frisitano merged commit 4836823 into main Aug 20, 2023
6 checks passed
@frisitano frisitano deleted the frisitano-asset-preservation branch August 20, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants