Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update names used for input/output notes #791

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Update names used for input/output notes #791

merged 3 commits into from
Jul 10, 2024

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Jul 9, 2024

This PR updates the nodes naming, changing "consumed" / "created" notes to "input" / "output" notes as it was suggested in the related issue: #778.

Also OffChain enum variant of the NoteType was renamed to Private.

@Fumuran Fumuran linked an issue Jul 9, 2024 that may be closed by this pull request
Update names used for input/output notes #778
Closed
@Fumuran Fumuran requested a review from bobbinth July 9, 2024 23:08
bobbinth
bobbinth approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I pushed a commit with some minor changes.

Other than that: let's update the changelog and especially document the breaking changes related to NoteType and Block struct updates.

@Fumuran Fumuran merged commit 5482077 into next Jul 10, 2024
12 checks passed
@Fumuran Fumuran deleted the andrew-update-notes-naming branch July 10, 2024 14:37
@Fumuran Fumuran mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update names used for input/output notes
2 participants
@Fumuran @bobbinth