feat: add re exports from base used in public api #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Jun 24, 2024
mFragaBA
commented
Jun 24, 2024
mFragaBA
commented
Jun 24, 2024
bobbinth
requested changes
Jun 24, 2024
bobbinth
approved these changes
Jun 25, 2024
mFragaBA
force-pushed
the
mFragaBA-add-re-exports-from-base-used-in-public-api
branch
2 times, most recently
from
cd9f09d
to
4945a84
Compare
In order to test this, I replicated the changes from this commit into `mFragaBA-workspace-refactor`, and tried making the integration tests compile without using miden-objects nor miden-tx as a dependency.
added more re-exports based on what I saw being imported in the [wasm fork](https://github.com/demox-labs/miden-client/).
mFragaBA
force-pushed
the
mFragaBA-add-re-exports-from-base-used-in-public-api
branch
from
4945a84
to
a16225c
Compare
bobbinth
pushed a commit
that referenced
this pull request
Jul 5, 2024
* refactor: add refactors from miden-objects and miden-tx * feat: add miden base re-exports on library crate In order to test this, I replicated the changes from this commit into `mFragaBA-workspace-refactor`, and tried making the integration tests compile without using miden-objects nor miden-tx as a dependency. * feat: add more miden base re-exports on library crate added more re-exports based on what I saw being imported in the [wasm fork](https://github.com/demox-labs/miden-client/). * refactor: flatten re-exports * address comments from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #280
Tested with:
mFragaBA-workspace-refactorwhich refactors the single crate structure into a miden-cli, miden-client and tests subcrates. This made it easier to test the usage of the client library as a dependency of the integration tests. I added it as a dependency (and didn't add miden-objects nor miden-tx) and added missing re-exports if any until it compiled.I think testing against real use cases instead of just looking at the api will avoid some missing re-exports problems. We can still iterate on this as users of the crate can decide when they remove the dependency and just use the re-exports instead.