test: Add Falcon signature tests. #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sentence describing the column $k_0$ had its order reversed, and the table headers were incorrectly named as $x_i$ and $y_i$ instead of $a_i$ and $b_i$ as described in the introduction.
…std-asm-utils Introduce `std::utils` assembly module
… info This commit changes the `import_info` fields of ProgramAst and ModuleAst to remove the `Option` wrapper, since it does not appear to serve a specific purpose, and both complicates access to the imports, and requires redundant code in a few places to access common information from the imports. It also required fallible checks in a few places where empty module import info would be suitable as a fallback. After this change, one can access the ModuleImports struct directly on both ProgramAst and ModuleAst via the `import_info` function, which returns a reference to the field. Redundant functions in both structs were removed if they are already provided by ModuleImports.
…c-fix docs(mdbook): minor change in the bitwise chiplet
…and-debug Expand capabilities of the `debug` instruction
…orconfig add .editorconfig
…oc-fix Minor doc fixes
…oc-fix-logup Minor doc fix LogUp
…host-event-handler Add `emit` instruction and host event handler
…precommit-sync Chore: pre-commit sync
* ContextId type * propagate MemoryContextId * fix tests * MemoryContextId -> ContextId * move definition * Remove derive-more dependency * fix repl * fmt * docstring * import newline * Remove `Sub` from `ContextId` * blank line * section name change * blank line * use `ContextId::root()` * fmt * memory context -> execution context
…-sig-tests Merge local and next branch.
…-sig-tests Merge local and next branch.
Up to date with next and merge conflicts gone. |
Al-Kindi-0
reviewed
Mar 5, 2024
|
Ready for review. |
|
@bobbinth Merged the latest from miden-crypto 0.9.0 into this PR. Ready for review. |
|
@scottdieringer thank you! Will review today - sorry for all the delays! |
bobbinth
reviewed
Apr 5, 2024
Al-Kindi-0
reviewed
Apr 5, 2024
|
@bobbinth Addressed PR comments, ready for review. |
bobbinth
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Addresses 1096 - Adding Falcon signature tests.
Adds following tests:
norm_sqprocedure, both overflow and underflow.diff_mod_qprocedure.powers_of_tauprocedure.load_h_s2_and_productprocedure to theprobabilistic_productprocedure. Both success and failure cases.adv.push_sig.rpo_falcon512procedure. Both success and failure cases.Checklist before requesting a review
nextaccording to naming convention.