Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Falcon test wrong parameter bounds #1320

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Fix Falcon test wrong parameter bounds #1320

merged 8 commits into from
Apr 30, 2024

Conversation

Al-Kindi-0
Copy link
Collaborator

Describe your changes

Fixing a test which failed at the boundaries of the parameter range.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

bobbinth
bobbinth approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! Could you revert some of the formatting changes to files other than falcon.rs? After that, we can merge.

@Al-Kindi-0
Copy link
Collaborator Author

Done!

@bobbinth bobbinth merged commit c2504b9 into next Apr 30, 2024
15 checks passed
@bobbinth bobbinth deleted the al-fix-falcon-test branch April 30, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al-Kindi-0 @bobbinth