BLAKE3 Hashing over 32 -bytes Input #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
…hashing Now cost of blake3 hashing over 32 -bytes input: 4820 -cycles Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
|
Does that mean it would also be faster to use the 64-bytes implementation for a hashchain instead of the 32-bytes? |
64 -bytes input case is cheaper in terms of VM cycles, which can prove to be faster in execution time, if hashchain is fairly long enough. Though it calls for much larger input to hashchain routine. |
bobbinth
requested changes
Nov 27, 2022
Following suggestion 0xPolygonMiden#563 (comment) Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
See 0xPolygonMiden#563 (comment) Also see 0xPolygonMiden#563 (comment) Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
|
At commit ae4258a
|
Thanks for the review. Can you please take a look once again ? |
Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
itzmeanjan
force-pushed
the
blake3-32B
branch
from
2d5bf5c
to
ae4258a
Compare
Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
|
Resolved merge conflict 34e9e3c |
itzmeanjan
added a commit
to itzmeanjan/miden
that referenced
this pull request
Nov 30, 2022
Following suggestions from 0xPolygonMiden#563 (comment) Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
This was referenced Nov 30, 2022
bobbinth
approved these changes
Nov 30, 2022
bobbinth
pushed a commit
that referenced
this pull request
Dec 10, 2022
Following suggestion #563 (comment) Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
bobbinth
pushed a commit
that referenced
this pull request
Dec 10, 2022
See #563 (comment) Also see #563 (comment) Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
bobbinth
pushed a commit
that referenced
this pull request
Dec 10, 2022
Following suggestions from #563 (comment) Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with 64 -bytes input, we can also hash 32 -bytes message, using BLAKE3.
Cost of hashing 32 -bytes: 4820 -cycles.