Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement u32 shl, shr, eq, neq, not #58

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Implement u32 shl, shr, eq, neq, not #58

merged 1 commit into from
Jan 18, 2022

Conversation

tnachen
Copy link
Contributor

@tnachen tnachen commented Jan 15, 2022

No description provided.

bobbinth
bobbinth requested changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some comments in-line.

assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
@tnachen tnachen requested a review from bobbinth January 15, 2022 16:43
bobbinth
bobbinth requested changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One more comment inline.

assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
@tnachen tnachen requested a review from bobbinth January 16, 2022 07:44
bobbinth
bobbinth requested changes Jan 16, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! A few more comments inline.

assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
bobbinth
bobbinth requested changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple more small comments.

assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
assembly/src/parsers/u32_ops.rs Outdated Show resolved Hide resolved
bobbinth
bobbinth approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thank you!

@bobbinth bobbinth merged commit 91a15e5 into 0xPolygonMiden:next Jan 18, 2022
@bobbinth bobbinth mentioned this pull request Jan 18, 2022
Merged
39 tasks
@bobbinth bobbinth mentioned this pull request Jan 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tnachen @bobbinth