Mark constant functions with const
#571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbraha
requested review from
0xaatif,
muursh,
Nashtare and
LindaGuiga
as code owners
github-actions
bot
added
crate: trace_decoder
Nashtare
approved these changes
Aug 30, 2024
0xaatif
approved these changes
Aug 30, 2024
Merged
muursh
approved these changes
Sep 2, 2024
|
Good stuff. May I suggest you also use the opportunity to add the lint to our CI, so we cannot merge code that violates this rule going forward? |
Let's discuss this in #587, @einar-polygon |
|
I wasn't aware of the nursery status. The current PR should be safe to merge. |
einar-polygon
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
constfor constant functions allows the compiler to evaluate them at compile-time, and allows the calling functions to beconst, too.These functions were detected with the clippy lint:
https://rust-lang.github.io/rust-clippy/master/index.html#/missing_const_for_fn