This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
orderwatch: Use consistent asynchronous API #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrow
commented
Jul 26, 2019
| @@ -112,9 +112,6 @@ func SetupOrderStream(ctx context.Context, app *core.App) (*ethRpc.Subscription, | |||
|
|
|||
| for { | |||
| select { | |||
| case <-ctx.Done(): | |||
There was a problem hiding this comment.
This fixes a bug in #304 that was previously unnoticed. ctx here is not something we control and it seems to be canceled even though a client is still actively subscribed. I can't find any documentation about the expected behavior of ctx at https://godoc.org/github.com/ethereum/go-ethereum/rpc. For now, we have no real choice but to ignore the given context.
albrow
commented
Jul 26, 2019
fabioberger
reviewed
Jul 26, 2019
zeroex/orderwatch/order_watcher.go
Outdated
| FillableTakerAssetAmount: orderInfo.FillableTakerAssetAmount, | ||
| Kind: zeroex.EKOrderExpired, | ||
| } | ||
| w.orderFeed.Send([]*zeroex.OrderEvent{orderEvent}) |
There was a problem hiding this comment.
An optimization here would be to append each OrderEvent to a slice and then send them all to orderFeed after the for loop has finished executing.
albrow
force-pushed
the
feature/orderwatch-consistent-async-api
branch
from
8a1ee5b
to
41fffa6
Compare
fabioberger
approved these changes
Jul 27, 2019
zeroex/orderwatch/order_watcher.go
Outdated
| logger.WithFields(logger.Fields{ | ||
| "error": err.Error(), | ||
| "orderHash": expiredOrder.ID, | ||
| }).Warning("Order expired that was no longer in DB") |
There was a problem hiding this comment.
Should we keep this as a Warning or lower this to a Trace? It is expected to happen from time to time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #96.