This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Implement low-level rate-limiting #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioberger
approved these changes
Oct 1, 2019
Co-Authored-By: Fabio B <me@fabioberger.com>
Co-Authored-By: Fabio B <me@fabioberger.com>
albrow
force-pushed
the
feature/low-level-rate-limiting
branch
from
524ecfb
to
89940f7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119.
This PR implements low-level rate-limiting and bans offending peers by their IP address. Currently, the limit on bandwidth usage is set conservatively high at 100 MiB/s. We can lower this limit over time as we get a better sense for what real world usage looks like.
This PR also will cause Mesh to log bandwidth statistics every 5 minutes, which will help us understand how much bandwidth is being used by each peer and each protocol over time. Technically, it would probably be better to report these statistics via Prometheus. However, since we already have the proxy and authentication infra set up for logging+EFK, I think it is okay to log them for now.
Also note that in order for this rate-limiting strategy to be effective we need to implement #390. In this PR, relay hosts are immune from being banned, so a spammer could simply use a relayed connection to circumvent the bandwidth limits. Once well-behaving relay hosts implement their own rate-limiting, we can safely differentiate misbehaving relay hosts from well-behaving ones and ban them.