This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Batch Order Matching #1900
Closed
Batch Order Matching #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
requested review from
abandeali1,
fabioberger and
hysz
as code owners
jalextowle
force-pushed
the
feature/contracts/3.0/batch-match-orders
branch
from
36fed4d
to
4c21215
Compare
jalextowle
force-pushed
the
feature/contracts/3.0/batch-match-orders
branch
from
9be6e56
to
c0196d8
Compare
|
Due to the fact that ZEIP 40 addresses several of the issues in this ZEIP, more tests for |
dorothy-zbornak
suggested changes
Jun 28, 2019
jalextowle
force-pushed
the
feature/contracts/3.0/batch-match-orders
branch
3 times, most recently
from
4a24d52
to
e24c55d
Compare
jalextowle
force-pushed
the
feature/contracts/3.0/batch-match-orders
branch
3 times, most recently
from
f484c88
to
5735e29
Compare
Co-Authored-By: Lawrence Forman <lawrence@0xproject.com>
jalextowle
force-pushed
the
feature/contracts/3.0/batch-match-orders
branch
2 times, most recently
from
3abb6cc
to
cff710c
Compare
jalextowle
force-pushed
the
feature/contracts/3.0/batch-match-orders
branch
from
cff710c
to
bbd5b86
Compare
dorothy-zbornak
suggested changes
Jul 2, 2019
| const _initialTokenBalances = initialTokenBalances | ||
| ? initialTokenBalances | ||
| : await this._initialTokenBalancesPromise; | ||
| // Execute `batchMatchOrders()` |
There was a problem hiding this comment.
Right before this, can we do an exchangeWrapper.getBatchMatchOrdersResultsAsync() and assert the results against the simulation? I don't see where we are checking the return value of batchMatchOrders() anywhere.
Would also be nice to have this done for the regular matchOrders() tests, as well.
| ); | ||
| } | ||
| } | ||
| // TODO(jalextowle): Implement the same as the above for ERC1155 |
There was a problem hiding this comment.
Do we have any matchOrders coverage for 1155s? Let's add an asana task for this.
There was a problem hiding this comment.
I'll check and get back to you.
jalextowle
added a commit
to jalextowle/0x-monorepo
that referenced
this pull request
Jul 2, 2019
jalextowle
added a commit
to jalextowle/0x-monorepo
that referenced
this pull request
Jul 3, 2019
jalextowle
added a commit
to jalextowle/0x-monorepo
that referenced
this pull request
Jul 3, 2019
jalextowle
added a commit
to jalextowle/0x-monorepo
that referenced
this pull request
Jul 17, 2019
abandeali1
pushed a commit
that referenced
this pull request
Jul 24, 2019
This was referenced Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR partially address ZEIP 41.
Batch Order Matching
These changes add a
batchMatchOrdersfunction, which allows several orders to be matched in a single transaction. This implementation can easily be modified to also meet the requirements forbatchMatchOrdersWithMaximalFillas soon as ZEIP 40 is implemented.Simulating Batch Order Matching
A
batchMatchOrdersAndAssertEffectsAsyncfunction was added to facilitate testing the newbatchMatchOrdersfunction, and in the process I was able to refactor some of thematch_order_tester.tsfile to be more general.Testing instructions
yarn build:contracts && yarn test:contracts && yarn lint:contractsTypes of changes
Checklist:
[WIP]if necessary.