Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update solidity binaries link #49

Merged

Conversation

gabririgo
Copy link
Contributor

Description

update link as per documentation available at: https://buildmedia.readthedocs.org/media/pdf/solidity/develop/solidity.pdf
This does not have download limits which get instead hit when using sol-compiler with multiple solc versions

Testing instructions

should work out of the box

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

- update solc binaries list link in compiler.ts
@gabririgo
Copy link
Contributor Author

hi @dorothy-zbornak is there an ETA when this bugfix can be pushed out?

@dorothy-zbornak
Copy link
Contributor

hi @dorothy-zbornak is there an ETA when this bugfix can be pushed out?

We can do this today! Can you please add the following entry to the top of sol-compiler/CHANGELOG.json?:

    {
        "version": "4.7.5",
        "changes": [
            {
                "note": "update solidity binaries link",
                "pr": 49
            }
        ]
    },

This is necessary for the publish job to pick up the changes.

update CHANGELOG.json
@gabririgo
Copy link
Contributor Author

done!

Copy link
Contributor

@dorothy-zbornak dorothy-zbornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@dorothy-zbornak dorothy-zbornak merged commit 2a679af into 0xProject:development Oct 27, 2021
@dorothy-zbornak
Copy link
Contributor

Published under 4.7.7 https://www.npmjs.com/package/@0x/sol-compiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants