Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Devnet Logo aligned with Starknet new logo #406

Merged
merged 8 commits into from
Apr 3, 2024
Merged

Update Devnet Logo aligned with Starknet new logo #406

merged 8 commits into from
Apr 3, 2024

Conversation

leoyoung-69
Copy link
Contributor

I have made a new logo of Starknet Devnet. The Starknet logo in the center is changed into the new one.

Thank you.

FabijanC
FabijanC requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@FabijanC FabijanC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't just change the logo, it also adds an unwanted grey background, as can be seen here:
https://media.discordapp.net/attachments/1178603291005947954/1224611637512638524/image.png?ex=661e1f76&is=660baa76&hm=b1a9ae7c636780cc07a19a9823543d9eb6c7e576da733701e968af0ac1a7c739&=&format=webp&quality=lossless&width=1282&height=623

@leoyoung-69
Copy link
Contributor Author

This PR doesn't just change the logo, it also adds an unwanted grey background, as can be seen here: https://media.discordapp.net/attachments/1178603291005947954/1224611637512638524/image.png?ex=661e1f76&is=660baa76&hm=b1a9ae7c636780cc07a19a9823543d9eb6c7e576da733701e968af0ac1a7c739&=&format=webp&quality=lossless&width=1282&height=623

Hey,

I think I have updated it here without grey background. I am going to modify the color later.

Thank you,

@FabijanC
Copy link
Contributor

FabijanC commented Apr 2, 2024

@leoyoung-69 your link is private

@leoyoung-69
Copy link
Contributor Author

leoyoung-69 commented Apr 2, 2024 •
edited
Loading

@FabijanC it shows no background in my forked repo. Is it right?

@leoyoung-69
Update README.md
0010f82 
Background is transparent and frame color is modified with new Starknet logo.
@leoyoung-69
Copy link
Contributor Author

leoyoung-69 commented Apr 3, 2024 •
edited
Loading

logo

@FabijanC I think I should upload the logo here.

@leoyoung-69
Copy link
Contributor Author

There is another one modified the keyboard frame color into light orange to align with the new logo color.
logo2

@FabijanC FabijanC merged commit ff6e10e into 0xSpaceShard:main Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hanae1963 Hanae1963 Hanae1963 approved these changes

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leoyoung-69 @FabijanC @Hanae1963