Refactor add_<declare/invoke/deploy_account>_transactions #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccount_transaction
FabijanC
requested changes
Apr 9, 2024
crates/starknet-devnet-core/src/starknet/add_deploy_account_transaction.rs
Outdated
Show resolved
Hide resolved
crates/starknet-devnet-core/src/starknet/add_invoke_transaction.rs
Outdated
Show resolved
Hide resolved
crates/starknet-devnet-core/src/starknet/add_deploy_account_transaction.rs
Outdated
Show resolved
Hide resolved
crates/starknet-devnet-core/src/starknet/add_deploy_account_transaction.rs
Outdated
Show resolved
Hide resolved
crates/starknet-devnet-types/src/rpc/transactions/broadcasted_declare_transaction_v1.rs
Outdated
Show resolved
Hide resolved
crates/starknet-devnet-types/src/rpc/transactions/broadcasted_declare_transaction_v2.rs
Outdated
Show resolved
Hide resolved
… implemented it on enum
FabijanC
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
closes #349
Development related changes
Refactor add_transaction methods. By combining handling cases of transaction versions
Replaced thread::sleep with Tokio::time::sleep in async methods
Added check for returning error when a query_only transaction is send in write endpoints
Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh