Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional check for invalid share & indentation #11

Closed
wants to merge 2 commits into from
Closed

additional check for invalid share & indentation #11

wants to merge 2 commits into from

Conversation

mining-visualizer
Copy link
Contributor

Hey, this is my first PR ever!

I messed up your indentation awhile back and its been bugging me, plus I wanted to add in that extra check for claimedTarget:

          var digestBigNumber = web3utils.toBN(digest);
          var claimedTarget = self.getTargetFromDifficulty( difficulty )

          if(computed_digest !== digest || digestBigNumber.gte(claimedTarget))
          {
            validJSONSubmit = false;
          }

I managed to get the pool software working on my Ubuntu laptop so I had a chance to test it out and it works ok.

@mining-visualizer
Copy link
Contributor Author

I just submitted a new pull request with the modified hash rate calculations, and it contains the changes in this one as well, so closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants