Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vevo videos not working #105

Closed
stefangomez opened this issue Jan 14, 2015 · 35 comments
Closed

vevo videos not working #105

stefangomez opened this issue Jan 14, 2015 · 35 comments
Labels
Milestone

Comments

@stefangomez
Copy link

Looks like there's a reoccurrence of #94 here. Anybody else having problems playing vevo/wmg videos?

@chawei
Copy link

chawei commented Jan 14, 2015

yea i have the same problem here.

@chrisnolet
Copy link

Was just about to post :) I'm not getting an error this time though; just no video/sound.

@imclean
Copy link

imclean commented Jan 14, 2015

same problem here

@Jellyfishinatrifle
Copy link

me too

@0xced 0xced added the bug label Jan 14, 2015
@0xced
Copy link
Owner

0xced commented Jan 14, 2015

YouTube changed its API again. I will investigate and try to publish a new version ASAP.

@0xced 0xced mentioned this issue Jan 15, 2015
@SoneeJohn
Copy link
Collaborator

For some odd reason my users are reporting the same issue: "Request failed: 403". I am guessing this is due, the the API change that you mentioned. However, I have not experienced this issue myself. I really hope this is fixed 👍 :-)

@0xced
Copy link
Owner

0xced commented Jan 15, 2015

Yes, the 403 error stems from the API change. This only happens for protected videos though.

@martinobonfiglioli
Copy link

Now it seem back to work again, slowly

@psycotica0
Copy link

I'm seeing the same from here: the previous technique is working again.

I don't know how to feel about it.
Suspicious, perhaps.

@nahum365
Copy link

Still not working for me. The playbackState on the MPMoviePlayer just never changes from buffering to playing.

@Cartman2000
Copy link

Yep not working either

@codaman
Copy link

codaman commented Jan 15, 2015

Has anybody tried older versions?? Which one is previous technique

@psycotica0
Copy link

Nevermind, it's stopped working for us again too. By previous technique I just meant whatever master was using.

@psycotica0
Copy link

Perhaps related, this is youtube_dls fix ytdl-org/youtube-dl@a9b6b5c

@codaman
Copy link

codaman commented Jan 16, 2015

İ've tried YouTube-dl. It also cannot download vevo videos. Have you tried it

@psycotica0
Copy link

Yeah, youtube_dl works after the commit I linked to above. Before that it did not.

@psycotica0
Copy link

Doing some debugging, it seems like the problem is that we're not getting the script we need to decode the signature. Putting code into XCDYouTubeVideoOperation.m's start function that downloads a hardcoded string of http://s.ytimg.com/yts/jsbin/html5player-en_US-vfl86Quee/html5player.js, and then uses XCDYouTubePlayerScript on that string makes it work.

@psycotica0
Copy link

Still not in a good place code-style wise. Working on a patch.

@psycotica0
Copy link

Ok, even better.

In XCDYouTubeVideoOperation:start, if instead of calling [self startNextVideoInfoRequest], you call [self startRequestWithURL: watch_page], where watch page is the page like "http://youtube.com/watch?v=STUFFSTUFF".

The code just takes it from there. I don't know, looking at the code, why this code path never seems to come up otherwise.

@psycotica0
Copy link

Alright, the code I borrow from elsewhere in the code to make my approach work seems to have come from an error handler. It's possible that the API used to tell us we needed to sign things, whereas now it just lets us submit unsigned things and rejects us.

@psycotica0
Copy link

Alright, so I think I've traced it back to the change. It looks like there used to be a value in the response called "use_cipher_signature" that, when true, told us we needed to fetch the script to decode things. This key appears to no longer be present.

@psycotica0
Copy link

Alright, the last thing that seems to have been needed was to make it so that a playerScript with no 's' parameter isn't considered an error. Patch getting cleaned up for some sort of review.

@chrisnolet
Copy link

Awesome, thanks for digging through this!

@psycotica0
Copy link

I've put a pull request up at my fork: #106

@SoneeJohn
Copy link
Collaborator

Thanks for looking into this issue @psycotica0. I will issue an update to my users and see if it fixes the problems they have been experiencing.

@0xced
Copy link
Owner

0xced commented Jan 18, 2015

I'd suggest waiting for an official update, the proposed fix breaks a lot of unit tests.

@SoneeJohn
Copy link
Collaborator

Yeah sure, that's why the update that I issued to my users is just a beta candidate. I will do an official release when the class gets an official update.

@nahum365
Copy link

I've also submitted an update with @psycotica0's fix. I hate to be the person to ask this, but is there a expected completion date on the official update?

@objectiveCarlo
Copy link

Hi guys I have a temporary fix in my fork: objectiveCarlo@932ce56

@hodalgun
Copy link

um... not working... same problem.. ㅠ.ㅠ

@K-IOS
Copy link

K-IOS commented Jan 22, 2015

I have the same problem here.
Any temporary solution to solve this ?

@chrisnolet
Copy link

I'm using @psycotica0's fix in the mean time too, although I understand that an official fix is on the way:

pod 'XCDYouTubeKit', :git => 'https://github.com/psycotica0/XCDYouTubeKit.git', :commit => '898d3105f424ba61a11bd1c7c8c88d3dbb386e94'

@hectordominguez00
Copy link

Is there any functional fix?

@0xced
Copy link
Owner

0xced commented Feb 3, 2015

The develop branch now contains a fix for this issue. I will publish an official update once I fix the age-restricted VEVO video issue.

@K-IOS
Copy link

K-IOS commented Feb 4, 2015

https://github.com/0xced/XCDYouTubeKit/tree/develop
Yes, Develop branch working.
Thanks

@0xced 0xced added this to the Version 2.1.0 milestone Feb 4, 2015
@0xced 0xced removed the next release label Feb 4, 2015
@0xced 0xced closed this as completed in 8a8a20d Feb 6, 2015
Hesowcharov pushed a commit to Hesowcharov/XCDYouTubeKit that referenced this issue Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests