Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide vextab via npm install & require('vetab') #55

Open
timaschew opened this issue Dec 5, 2014 · 12 comments
Open

provide vextab via npm install & require('vetab') #55

timaschew opened this issue Dec 5, 2014 · 12 comments

Comments

@timaschew
Copy link
Contributor

This issue come from here: #53 (comment)

The next goal should be to support other module loader, as I explained here via a UMD: #53 (comment)

@0xfe
Copy link
Owner

0xfe commented Dec 5, 2014

Working on it. :-)

@timaschew
Copy link
Contributor Author

Okay fine :)
poke me if you need help

@0xfe
Copy link
Owner

0xfe commented Dec 5, 2014

Will do. Thanks.

-- sent frm fone
On Dec 5, 2014 3:11 PM, "Anton Wilhelm" notifications@github.com wrote:

Okay fine :)
poke me if you need help


Reply to this email directly or view it on GitHub
#55 (comment).

@timaschew
Copy link
Contributor Author

I tried to require vextab via npm, but it doesn't work, because of this line: ff5877a#diff-35f81cb6401704ff630d0f1f39a22707R11

And currently it only works if you use browserify, it would be work with any tool, if you add a prepublish step for npm and publish the js files instead of the coffee files.

@timaschew
Copy link
Contributor Author

I can do PR with a fix.
would you like the solution to use a prepublish step to provide vextab as javascript via npm?

@0xfe
Copy link
Owner

0xfe commented Mar 10, 2015

I'm out of town till Apr 2nd. Will take a look when I'm back.

-- sent frm fone
On Mar 10, 2015 2:08 PM, "Anton Wilhelm" notifications@github.com wrote:

should a make a PR to fix it?
would you like the solution to use a prepublish step to provide vextab as
javascript via npm?


Reply to this email directly or view it on GitHub
#55 (comment).

@vojty
Copy link

vojty commented Feb 1, 2017

@0xfe hi, what is the status of this? I'd like to send you PR with js build, so you can publish pure JS module to npm, but I am not able to run tests from master, i have basically this problem: https://travis-ci.org/0xfe/vextab/builds/157201147

@hrgui
Copy link

hrgui commented Feb 5, 2017

Same here, requiring vextab requires something that understands coffeescript, as a workaround I just included vextab-div seperate from my bundle...

@vojty
Copy link

vojty commented Feb 5, 2017

@hrgui I have prepared PR #90 with commonjs build

@SalahAdDin
Copy link

@vojty what's about this?

@vojty
Copy link

vojty commented Feb 26, 2017

@SalahAdDin well my PR is almost mergeable, but I need help with tests. Current master branch has some issues #92 maybe @0xfe could help...

@SalahAdDin
Copy link

@0xfe @vojty I think he could.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants