Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notation-vs-tab bar misalignment #122

Merged
merged 6 commits into from
Apr 20, 2021

Conversation

jzohrab
Copy link
Contributor

@jzohrab jzohrab commented Apr 20, 2021

Hi @0xfe / Mohit,

This PR fixes a bar misalignment mentioned in #99, and PR #120. Prior to this PR, this works (bars aligned)

tabstave notation=true key=E time=12/8
notes :w 7/4 | 6/5

But this breaks (bars misaligned)

tabstave notation=true key=E time=12/8
notes :w 7/4 | 6/5 |

In this branch I added some very simple tests verifying the fix: code is rendered and the SVG is compared, eg:

image

Note that I pulled the single-line code fix from issue #99 -- I couldn't quite see why this fixed the issue, but it did! The existing tests pass.

@jzohrab jzohrab mentioned this pull request Apr 20, 2021
Copy link
Owner

@0xfe 0xfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Thanks for the change and for fixing the tests. Some minor comments.

tests/tests.coffee Outdated Show resolved Hide resolved
tests/tests.coffee Outdated Show resolved Hide resolved
@jzohrab
Copy link
Contributor Author

jzohrab commented Apr 20, 2021

Thanks @0xfe ! This will close out #99 . Cheers, jz

Copy link
Owner

@0xfe 0xfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, merging!

@0xfe 0xfe merged commit 42c213e into 0xfe:master Apr 20, 2021
@jzohrab jzohrab deleted the fix-score-tab-bar-alignment branch April 24, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants