Migrate VexTab to VexFlow 4.0.0. #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronyeh
commented
Nov 6, 2021
| @@ -625,7 +625,7 @@ class Artist | |||
| fingerings = @makeFingering(annotations[i]) | |||
| if fingerings? | |||
| try | |||
| (note.addModifier(fingering.num, fingering.modifier) for fingering in fingerings) | |||
| (note.addModifier(fingering.modifier, fingering.num) for fingering in fingerings) | |||
There was a problem hiding this comment.
Possible bug fix? Or did an old version of VexFlow have the arguments reversed? Anyways, it was throwing an exception so I switched the two arguments.
| @@ -44,7 +44,7 @@ class VexTab | |||
| notation_option = option | |||
| throw error("'#{option.key}' must be 'true' or 'false'") if option.value not in ["true", "false"] | |||
| when "key" | |||
| throw error("Invalid key signature '#{option.value}'") unless _.has(Vex.Flow.keySignature.keySpecs, option.value) | |||
| throw error("Invalid key signature '#{option.value}'") unless Vex.Flow.hasKeySignature(option.value) | |||
There was a problem hiding this comment.
It seemed cleaner to have a method called hasKeySignature(), so I added it to VexFlow.
| @@ -197,7 +197,7 @@ class VexTabTests | |||
|
|
|||
| # KEY SIGNATURE TESTS | |||
|
|
|||
| for key of Vex.Flow.keySignature.keySpecs | |||
| for key of Vex.Flow.getKeySignatures() | |||
There was a problem hiding this comment.
Similarly, I added a getter here instead of allowing client code to reach into the internals of VexFlow.
|
This is the commit that added some backwards compatibility and some new methods to VexFlow, to support this migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes VexTab compatible with the VexFlow 4.0.0-alpha at:
https://github.com/ronyeh/vexflow/tree/4.0.0-alpha