Fixed parser name. Fixed Gemfile and Rakefile. #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @0xfe
I made some minor changes to your library. First of all I fixed an issue with the naming of the parser exported by vextab.coffee, that was causing the
vextab_parser is undefined
as mentioned in issue #49 and also was failing all the tests.I also switched the
sh
command in the Rakefile, migrating to the backquote command. This was causing an issue when running the rake tasks in a ZSH shell, using rbenv (the wrong ruby was called).I removed therubyracer from the Gemfile, and added libv8 instead. therubyracer has some issues right now with OsX Yosemite.
Thanks for your great work.
Cheers