Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with the standard for operatorSend and operatorBurn #56

Closed
daejunpark opened this issue Aug 10, 2018 · 1 comment
Closed

Comments

@daejunpark
Copy link

daejunpark commented Aug 10, 2018

There is a discrepancy between the standard and the reference implementation regarding the operatorSend and operatorBurn functions:

The current standard (https://github.com/ethereum/EIPs/blob/b41669ede219b9599a6a1c637e578b8a444ad6b1/EIPS/eip-777.md):

The value of from MAY be 0x0, then the from (token holder) used for the send MUST be msg.sender (the operator).

The current reference implementation of both operatorSend and operatorBurn:

https://github.com/jacquesd/ERC777/blob/896d077eb4b1beb0fc2258f9d4dff4b60478a479/contracts/ERC777BaseToken.sol#L118-L121

https://github.com/jacquesd/ERC777/blob/896d077eb4b1beb0fc2258f9d4dff4b60478a479/contracts/ERC777BaseToken.sol#L127-L130

@daejunpark daejunpark changed the title Inconsistency with the standard for operatorSend Inconsistency with the standard for operatorSend and operatorBurn Aug 10, 2018
@0xjac
Copy link
Owner

0xjac commented Apr 6, 2019

This has actually been removed from the spec. I checked and the implementation should now match the spec with respect to this topic.

@0xjac 0xjac closed this as completed Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants