Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for peerListUpdated API #1228

Merged
merged 21 commits into from
Oct 5, 2023
Merged

Added support for peerListUpdated API #1228

merged 21 commits into from
Oct 5, 2023

Conversation

ygit
Copy link
Member

@ygit ygit commented Sep 21, 2023

Description

Closes

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@ygit ygit added enhancement New feature or request P0 High Priority Critical Task. P0 > P1 > P2 labels Sep 21, 2023
@ygit ygit linked an issue Sep 21, 2023 that may be closed by this pull request
🚀 Add new Peer List update event listener #1222
Closed
@ygit ygit changed the base branch from main to develop September 21, 2023 09:43
ygit
ygit commented Sep 21, 2023
View reviewed changes
packages/react-native-hms/src/classes/HMSSDK.tsx Outdated
@@ -1182,6 +1185,29 @@ export class HMSSDK {
return HMSManager.lowerRemotePeerHand(data);
};


getPeerListIterator = (options?: HMSPeerListIteratorOptions): HMSPeerListIterator => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stanwolverine since this is a synchronous operation do we need any decorators/declarations here?

@ygit ygit marked this pull request as ready for review September 21, 2023 11:14
stanwolverine
stanwolverine approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@stanwolverine stanwolverine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanwolverine stanwolverine merged commit 7b09eeb into develop Oct 5, 2023
1 check passed
@stanwolverine stanwolverine deleted the feature/updatePeerListAPIs branch October 5, 2023 14:36
stanwolverine added a commit that referenced this pull request Oct 5, 2023
@stanwolverine @ygit
Release 2.0.0-alpha: Develop to main (#1235)
ab068e5 
* updated packages

* updated package version

* released sample app version 2.3.73 (324) ⚛️

* updated SDK versions

* deleted nested `.gitignore` files

* fastlane script run changes

* sample apps changes

* added android hand raise APIs

* added isHandRaise options

* added hand raise APIs on JS

* resolved lint warnings

* feat(sdk): ✨ added raise hand first class apis on ios

* updated parsing

* feat(prebuilt): ✨ added 'hand raise' first class api usage in prebuilt

* resolved lint warnings

* upgraded `android sdk` version

* released sample app version 2.3.73 (324) ⚛️

* release df app changes

* updated gems

* updated script

* released sample app version 2.3.73 (324) ⚛️

* released sample app version 2.3.74 (325) ⚛️

* updated gradle

* Added GitHub actions (#1229)

* added github actions

* updated workflow name

* updated ReadMe

* updated build script

* Update README.md

* Added support for peerListUpdated API (#1228)

* added peer list updated event

* added peer list iterator APIs

* added peer list iterator implementation

* updated check

* feat(sdk): ✨ added `ON_PEER_LIST_UPDATED` event on RN SDK

* fix(sdk): 🐛 added `sdkId` in `ON_PEER_LIST_UPDATED` event payload

* feat(prebuilt): ✨ added `ON_PEER_LIST_UPDATED` event usage

* added iOS implementation for onPeerListUpdate event

* updated example app changelog

* released sample app version 2.3.75 (326) ⚛️

* updated changelog

* converting types to Double before adding to list

* resolved lint warnings

* released sample app version 2.3.77 (328) ⚛️

* fix(sdk): 🐛 `lowerLocalPeerHand` api not working

* refactor(sdk): ♻️ peerlistiterator code refactoring and minor change

---------

Co-authored-by: Jatin Nagar <jatin.nagar@100ms.live>

* Feature/android auto enter pip support (#1231)

* added peer list updated event

* added peer list iterator APIs

* added peer list iterator implementation

* updated check

* feat(sdk): ✨ added `ON_PEER_LIST_UPDATED` event on RN SDK

* fix(sdk): 🐛 added `sdkId` in `ON_PEER_LIST_UPDATED` event payload

* feat(prebuilt): ✨ added `ON_PEER_LIST_UPDATED` event usage

* added iOS implementation for onPeerListUpdate event

* updated example app changelog

* released sample app version 2.3.75 (326) ⚛️

* updated changelog

* converting types to Double before adding to list

* resolved lint warnings

* released sample app version 2.3.77 (328) ⚛️

* feat(sdk): ✨ added auto enter pip support in android

* refactor(example-app): usage of `enterPipMode` method

* feat(prebuilt): ✨ added auto enter pip support in prebuilt

* feat(example-app): ✨ added auto enter pip support in example app

* updated podfile

* feat(sdk): ✨ added auto enter pip support for android sdk less than 12

* feat(example-app): ✨ added auto enter pip support in example app for android sdk less than 12

* fix(sdk): 🐛 `lowerLocalPeerHand` api not working

* build(prebuilt): removed `react-native-keyboard-controller` lib

it was causing issues with pip window

* released sample app version 2.3.78 (329) and 2.3.80 (331) ⚛️

* refactor(sdk): ♻️ peerlistiterator code refactoring and minor change

---------

Co-authored-by: Yogesh Singh <yogesh@100ms.live>
Co-authored-by: ygit <ygit@users.noreply.github.com>

* Fix/light theme issues (#1233)

* added peer list updated event

* added peer list iterator APIs

* added peer list iterator implementation

* updated check

* feat(sdk): ✨ added `ON_PEER_LIST_UPDATED` event on RN SDK

* fix(sdk): 🐛 added `sdkId` in `ON_PEER_LIST_UPDATED` event payload

* feat(prebuilt): ✨ added `ON_PEER_LIST_UPDATED` event usage

* added iOS implementation for onPeerListUpdate event

* updated example app changelog

* released sample app version 2.3.75 (326) ⚛️

* updated changelog

* converting types to Double before adding to list

* resolved lint warnings

* released sample app version 2.3.77 (328) ⚛️

* feat(sdk): ✨ added auto enter pip support in android

* refactor(example-app): usage of `enterPipMode` method

* feat(prebuilt): ✨ added auto enter pip support in prebuilt

* feat(example-app): ✨ added auto enter pip support in example app

* updated podfile

* feat(sdk): ✨ added auto enter pip support for android sdk less than 12

* feat(example-app): ✨ added auto enter pip support in example app for android sdk less than 12

* fix(sdk): 🐛 `lowerLocalPeerHand` api not working

* build(prebuilt): removed `react-native-keyboard-controller` lib

it was causing issues with pip window

* released sample app version 2.3.78 (329) and 2.3.80 (331) ⚛️

* refactor(sdk): ♻️ peerlistiterator code refactoring and minor change

* fix(prebuilt): 💄 light theme color fixes

* released sample app version 2.3.81 (332) ⚛️

* fix(prebuilt): ✨ ligth theme issue in "Welcome to Meeting" screen

---------

Co-authored-by: Yogesh Singh <yogesh@100ms.live>
Co-authored-by: ygit <ygit@users.noreply.github.com>

* Fix-Prebuilt/change name feature for all (#1234)

* added peer list updated event

* added peer list iterator APIs

* added peer list iterator implementation

* updated check

* feat(sdk): ✨ added `ON_PEER_LIST_UPDATED` event on RN SDK

* fix(sdk): 🐛 added `sdkId` in `ON_PEER_LIST_UPDATED` event payload

* feat(prebuilt): ✨ added `ON_PEER_LIST_UPDATED` event usage

* added iOS implementation for onPeerListUpdate event

* updated example app changelog

* released sample app version 2.3.75 (326) ⚛️

* updated changelog

* converting types to Double before adding to list

* resolved lint warnings

* released sample app version 2.3.77 (328) ⚛️

* feat(sdk): ✨ added auto enter pip support in android

* refactor(example-app): usage of `enterPipMode` method

* feat(prebuilt): ✨ added auto enter pip support in prebuilt

* feat(example-app): ✨ added auto enter pip support in example app

* updated podfile

* feat(sdk): ✨ added auto enter pip support for android sdk less than 12

* feat(example-app): ✨ added auto enter pip support in example app for android sdk less than 12

* fix(sdk): 🐛 `lowerLocalPeerHand` api not working

* build(prebuilt): removed `react-native-keyboard-controller` lib

it was causing issues with pip window

* released sample app version 2.3.78 (329) and 2.3.80 (331) ⚛️

* refactor(sdk): ♻️ peerlistiterator code refactoring and minor change

* fix(prebuilt): 💄 light theme color fixes

* released sample app version 2.3.81 (332) ⚛️

* fix(prebuilt): ✨ ligth theme issue in "Welcome to Meeting" screen

* fix(prebuilt): 🐛 change name feature were not available for all roles

viewer-realtime, viewer-near-realtime and viewer-on-stage roles were not getting "change name" option

* released sample app version 2.3.82 (333) ⚛️

* fix(sdk): 🐛 lower local peer hand api on ios

* updated 100ms android and ios dependencies

* released sample app version 2.3.83 (334) ⚛️

---------

Co-authored-by: Yogesh Singh <yogesh@100ms.live>
Co-authored-by: ygit <ygit@users.noreply.github.com>

---------

Co-authored-by: Yogesh Singh <yogesh@100ms.live>
Co-authored-by: ygit <ygit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanwolverine stanwolverine stanwolverine approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request P0 High Priority Critical Task. P0 > P1 > P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Add new Peer List update event listener
2 participants
@ygit @stanwolverine