Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move auto layer selection, video render to core sdk #1092

Merged
merged 77 commits into from
Mar 3, 2023

Conversation

raviteja83
Copy link
Collaborator

@raviteja83 raviteja83 commented Nov 29, 2022

WEB-1372
Summary Move visibility handling and autolayer selection from react-sdk to hms-video-web
Type Task Task
Status In Progress
Points N/A
Labels qa-test

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Implementation note, gotchas, related work and Future TODOs (optional)

  • PIP not working as of now

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 2:20PM (UTC)
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 2:20PM (UTC)

@raviteja83 raviteja83 marked this pull request as draft November 29, 2022 11:14
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 55.28 KB (+2.91% 🔺)
packages/hms-video-web/dist/index.js 55.07 KB (+2.89% 🔺)
packages/hms-video-store/dist/index.cjs.js 16.02 KB (0%)
packages/hms-video-store/dist/index.js 15.79 KB (-0.02% 🔽)
packages/react-ui/dist/index.cjs.js 12.29 KB (-0.1% 🔽)
packages/react-ui/dist/index.js 688 B (0%)
packages/hms-virtual-background/dist/index.cjs.js 5.19 KB (0%)
packages/hms-virtual-background/dist/index.js 4.93 KB (0%)
packages/hms-noise-suppression/dist/index.cjs.js 2.13 KB (0%)
packages/hms-noise-suppression/dist/index.js 1.87 KB (0%)

@github-actions github-actions bot added Task and removed Task labels Mar 2, 2023
@raviteja83 raviteja83 requested a review from triptu March 2, 2023 13:59
triptu
triptu previously approved these changes Mar 2, 2023
@raviteja83 raviteja83 merged commit 2652531 into main Mar 3, 2023
@raviteja83 raviteja83 deleted the feat/WEB-1372 branch March 3, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants