Support compilation for x86 as a static library using CMake. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back with C++20. Since we basically stay compatible to C++11 I've disabled the pedantic warning for designated initalizers.
aentinger
added
topic: software
|
Hi @pavel-kirienko ☕ 👋 I've got some issue (invalid use of incomplete type) with my forward declarations. It works, but the compiler is not happy when I turn up -Wpedantic/-Werror: -Arduino-Cyphal/src/Publisher.ipp: In member function ‘bool impl::Publisher<T>::publish(const T&)’:
107-Arduino-Cyphal/src/Publisher.ipp:45:10: error: invalid use of incomplete type ‘class Node’ [-Werror]
45 | return _node_hdl.enqueue_transfer(_tx_timeout_usec,
| ^~~~~~~~~
107-Arduino-Cyphal/src/Publisher.hpp:21:7: note: forward declaration of ‘class Node’
21 | class Node;
| ^~~~I'm not sure how to best solve this, as both Node and Publisher use the other class. Do you have any suggestion? |
|
You cannot invoke methods on an incomplete type, so |
|
Thank you for the pointer, I managed to break the circular dependency by extracting base classes into a separate header file (and inventing one, where none existed before). |
…eparate header file breaks the circular dependency.
…r (no need for #ifdef LIB... anymore).
…lib ... this leads to liblibname file which causes issues down the road.
This makes sense as it does not change over time.
…. This could probably be bundled in an external library all-together.
…c type unpacking, which would actually require C++17 but for some reason compiles on Arduino also below ++11.
|
Memory usage change @ 6ee8649
Click for full report table
Click for full report CSV |
pavel-kirienko
requested changes
Jan 17, 2023
extras/cyphal++/examples/example-01-opencyphal-basic-node/README.md
Outdated
Show resolved
Hide resolved
|
Memory usage change @ 779617e
Click for full report table
Click for full report CSV |
extras/cyphal++/examples/example-01-opencyphal-basic-node/README.md
Outdated
Show resolved
Hide resolved
…ME.md Do as Pavel says. Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
pavel-kirienko
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #176.