Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support compilation for x86 as a static library using CMake. #201

Merged
merged 56 commits into from
Jan 17, 2023
Merged

Support compilation for x86 as a static library using CMake. #201

merged 56 commits into from
Jan 17, 2023

Commits on Jan 11, 2023

  1. Adding a minimal CMakeLists.txt to build this library as a static C++… 

    … library.
    @aentinger
    aentinger committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    c2144fe View commit details
    Browse the repository at this point in the history

  2. C++11 dropped designated initializers (what a shame). They only come … 

    …back with C++20. Since we basically stay compatible to C++11 I've disabled the pedantic warning for designated initalizers.
    @aentinger
    aentinger committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    faf0749 View commit details
    Browse the repository at this point in the history

  3. Parameter req not used, dropping it.

    @aentinger
    aentinger committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    9c54345 View commit details
    Browse the repository at this point in the history

  4. Adding CI build smoke test.

    @aentinger
    aentinger committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    f2062bf View commit details
    Browse the repository at this point in the history

  5. Eliminating unused parameters.

    @aentinger
    aentinger committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    e0e5e97 View commit details
    Browse the repository at this point in the history

  6. Fix deprecated-copy warning.

    @aentinger
    aentinger committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    3ffcb9c View commit details
    Browse the repository at this point in the history

  7. Improve conditional code flow.

    @aentinger
    aentinger committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    bda6916 View commit details
    Browse the repository at this point in the history

  8. Enable -Werror.

    @aentinger
    aentinger committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    b1d09cb View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Breaking out the base class (and make one, where non exists) into a s… 

    …eparate header file breaks the circular dependency.
    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    362e894 View commit details
    Browse the repository at this point in the history

  2. Add libsocketcan to CMake build not to Arduino build.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    10a660c View commit details
    Browse the repository at this point in the history

  3. Adding C++ wraper around C socketcan driver.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    711282c View commit details
    Browse the repository at this point in the history

  4. Minimal documentation of how to build this library as a static C++ li… 

    …brary.
    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c8aeb83 View commit details
    Browse the repository at this point in the history

  5. Adding minimum executable and move host source code into extras folde… 

    …r (no need for #ifdef LIB... anymore).
    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f636142 View commit details
    Browse the repository at this point in the history

  6. Create proper library structure.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    54c3f34 View commit details
    Browse the repository at this point in the history

  7. Fix compilation (Note: do not ever prefix a library target name with … 

    …lib ... this leads to liblibname file which causes issues down the road.
    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    3a9feef View commit details
    Browse the repository at this point in the history

  8. Fixing typo to o1heap.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    92c021c View commit details
    Browse the repository at this point in the history

  9. Pass unique id by reference, saves one copy.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    290260a View commit details
    Browse the repository at this point in the history

  10. Implementing a very basic OpenCyphal node.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    926351b View commit details
    Browse the repository at this point in the history

  11. Renaming to be consistent with Ardunio examples.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    870f446 View commit details
    Browse the repository at this point in the history

  12. A simple millis() function simplifies the code somewhat.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    9508028 View commit details
    Browse the repository at this point in the history

  13. Implementing code for receiving.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f08b9b6 View commit details
    Browse the repository at this point in the history

  14. Prevent race conditions via locking.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    145f056 View commit details
    Browse the repository at this point in the history

  15. Enable usage of a single library include only.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    17c601b View commit details
    Browse the repository at this point in the history

  16. A better solution for the header file situation.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    050d30b View commit details
    Browse the repository at this point in the history

  17. Rename to libcyphal++.

    @aentinger
    aentinger committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    da71a31 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Adding script for setting up virtual can.

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    4a9b5d0 View commit details
    Browse the repository at this point in the history

  2. Fix: Erroneous handling of deadline lead to no CAN frame being sent.

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    7867bdf View commit details
    Browse the repository at this point in the history

  3. Fix: we need a clock that does not progress when we halt the program … 

    …via break to inspect state.
    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    425d073 View commit details
    Browse the repository at this point in the history

  4. Adding some very basic documentation.

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    8297a08 View commit details
    Browse the repository at this point in the history

  5. Remove trailing whitespaces.

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    a5a3396 View commit details
    Browse the repository at this point in the history

  6. Fix spelling.

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    7a9e035 View commit details
    Browse the repository at this point in the history

  7. Add candump to documentation.

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    02899d8 View commit details
    Browse the repository at this point in the history

  8. Fix: uptime is in seconds, not milliseconds.

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    d57204a View commit details
    Browse the repository at this point in the history

  9. Improve documentation on how to invoke the setup scripts. 

    Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
    @aentinger @pavel-kirienko
    aentinger and pavel-kirienko committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    319d78f View commit details
    Browse the repository at this point in the history

  10. Consting for file descriptor. 

    Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
    @aentinger @pavel-kirienko
    aentinger and pavel-kirienko committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    ee06f9b View commit details
    Browse the repository at this point in the history

  11. Drop virtual prefix from method that overrides. 

    Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
    @aentinger @pavel-kirienko
    aentinger and pavel-kirienko committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    6131cf4 View commit details
    Browse the repository at this point in the history

  12. Rule-of-5 (and all that).

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    cd78218 View commit details
    Browse the repository at this point in the history

  13. Prevent further inheritance from Publisher. 

    Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
    @aentinger @pavel-kirienko
    aentinger and pavel-kirienko committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    569942c View commit details
    Browse the repository at this point in the history

  14. Use final to prevent further inheritance.

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    b9a15bb View commit details
    Browse the repository at this point in the history

  15. Drop virtual prefix for override member functions.

    @aentinger
    aentinger committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    98ad67b View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Mark setup_yakut.sh as executable.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    db5d502 View commit details
    Browse the repository at this point in the history

  2. Using std::find saves iterating over the same std::map twice.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    abaa99e View commit details
    Browse the repository at this point in the history

  3. Improve documentation.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    1dd3629 View commit details
    Browse the repository at this point in the history

  4. Turn CAN transmit function into a member variable (again). 

    This makes sense as it does not change over time.
    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    0efaabc View commit details
    Browse the repository at this point in the history

  5. No need for defining the empty response, automatically done in ctor.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f489043 View commit details
    Browse the repository at this point in the history

  6. Move SocketCAN.h/.cpp out of cyphal++ library and into 'libsocketcan'… 

    …. This could probably be bundled in an external library all-together.
    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    b7653e4 View commit details
    Browse the repository at this point in the history

  7. A dedicated CanRxItem eliminates the need for std::tuple and automati… 

    …c type unpacking, which would actually require C++17 but for some reason compiles on Arduino also below ++11.
    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c77a2d5 View commit details
    Browse the repository at this point in the history

  8. Using peek/pop eliminates unnecessary copy-ing.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    43e54cf View commit details
    Browse the repository at this point in the history

  9. Rename registers to from uavcan to cyphal.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f1ffd2b View commit details
    Browse the repository at this point in the history

  10. Adding missing newline.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    e858604 View commit details
    Browse the repository at this point in the history

  11. Fix: Usage of unassigned variable.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    b0d31bb View commit details
    Browse the repository at this point in the history

  12. Fix: add missing include for unique_ptr.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    5237c5e View commit details
    Browse the repository at this point in the history

  13. Add required include for strlen.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    7cbb949 View commit details
    Browse the repository at this point in the history

  14. canard_transfer_kind can be protected.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    6ee8649 View commit details
    Browse the repository at this point in the history

  15. Fix how to initialize virtual can.

    @aentinger
    aentinger committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    779617e View commit details
    Browse the repository at this point in the history

  16. Update extras/cyphal++/examples/example-01-opencyphal-basic-node/READ… 

    …ME.md


Do as Pavel says.

Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
    @aentinger @pavel-kirienko
    aentinger and pavel-kirienko committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    e3f095a View commit details
    Browse the repository at this point in the history