Fix: overload 'get' in order to enable std::string as supported parameters. #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aentinger
added
topic: firmware
|
Ah, interesting. The compiler chose inline void set(Value& dst, const std::string& string)
{
set(dst, std::string_view(string));
} |
|
Now explicitly overloading for |
|
Memory usage change @ b9f4393
Click for full report table
Click for full report CSV |
|
That's also easy -- add another overload: inline void set(Value& dst, const char* const string)
{
set(dst, std::string_view(string));
}
`` |
|
Thank you @pavel-kirienko 🙇 . This compiles now, I'll ask @generationmake to perform some tests. |
|
Memory usage change @ d69d9a6
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggest by @pavel-kirienko over here.
Unfortunately leads to a really ugly error message ...
In file included from /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/util/nodeinfo/../../types/uavcan/node/port/ID_1_0.hpp:51, from /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/util/nodeinfo/../../DSDL_Types.h.impl:11, from /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/util/nodeinfo/../../DSDL_Types.h:20, from /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/util/nodeinfo/NodeInfoBase.hpp:17, from /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/Node.hpp:30, from /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/107-Arduino-Cyphal.h:15, from /home/alex/projects/107-systems/OpenCyphalPicoBase-firmware/OpenCyphalPicoBase-firmware.ino:18: /home/alex/.arduino15/packages/rp2040/tools/pqt-gcc/1.5.0-a-5007782/arm-none-eabi/include/c++/12.2.0/variant: In substitution of 'template<unsigned int _Np, class ... _Args> std::enable_if_t<(!(_Np < 15)), void> std::variant<uavcan::primitive::Empty_1_0, uavcan::primitive::String_1_0, uavcan::primitive::Unstructured_1_0, uavcan::primitive::array::Bit_1_0, uavcan::primitive::array::Integer64_1_0, uavcan::primitive::array::Integer32_1_0, uavcan::primitive::array::Integer16_1_0, uavcan::primitive::array::Integer8_1_0, uavcan::primitive::array::Natural64_1_0, uavcan::primitive::array::Natural32_1_0, uavcan::primitive::array::Natural16_1_0, uavcan::primitive::array::Natural8_1_0, uavcan::primitive::array::Real64_1_0, uavcan::primitive::array::Real32_1_0, uavcan::primitive::array::Real16_1_0>::emplace(_Args&& ...) [with unsigned int _Np = 896; _Args = <missing>]': /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/util/registry/registry_value.hpp:96:67: recursively required from 'constexpr const std::size_t registry::detail::ArraySelector<char, 1, void>::Index' /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/util/registry/registry_value.hpp:96:67: required from 'constexpr const std::size_t registry::detail::ArraySelector<char, 0, void>::Index' /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/util/registry/registry_value.hpp:214:57: required by substitution of 'template<class Container, class T, unsigned int Index> void registry::set(Value&, const Container&) [with Container = std::__cxx11::basic_string<char>; T = char; unsigned int Index = <missing>]' /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/util/registry/registry_impl.hpp:326:26: required from 'registry::ValueWithMetadata registry::Registry::Reg<N, G, S, IsMutable>::get() const [with N = std::basic_string_view<char>; G = registry::Registry::expose<const char (&)[24], std::__cxx11::basic_string<char> >(const char (&)[24], const Options&, std::__cxx11::basic_string<char>&)::<lambda()>; S = registry::Registry::expose<const char (&)[24], std::__cxx11::basic_string<char> >(const char (&)[24], const Options&, std::__cxx11::basic_string<char>&)::<lambda(const registry::Value&)>; bool IsMutable = true]' /home/alex/Arduino/libraries/107-Arduino-Cyphal/src/util/registry/registry_impl.hpp:323:41: required from here /home/alex/.arduino15/packages/rp2040/tools/pqt-gcc/1.5.0-a-5007782/arm-none-eabi/include/c++/12.2.0/variant:1586:49: fatal error: template instantiation depth exceeds maximum of 900 (use '-ftemplate-depth=' to increase the maximum) 1586 | enable_if_t<!(_Np < sizeof...(_Types))> emplace(_Args&&...) = delete; | ^~~~~~~ compilation terminated.CC @generationmake