-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to view all post types when Pulling from an External Connection #861
Comments
Noting that https://github.com/10up/distributor/tree/feature/861 may be a good start on this, so we'll want to credit @chigozieorunta once this issue gets resolved. |
As work in beginning on Distributor 2.0.0, I've moved this enhancement off the 1.7.0 milestone to allow the point release to focus on bug fixes. |
@jeffpaul I have worked on this with the branch |
@mehul0810 This PR is also there, please check if there's something you can spot or helpful. |
I've moved this to 2.0.1 as the REST API endpoint this relies on will be getting modified in 2.0.0. |
@jeffpaul I have reviewed and updated the PR to achieve the functionality as mentioned in the issue. Can you please review? Also, I noticed that some GH actions for E2E are failing saying no report files. Are we aware of that? If not, we need to tackle that in separate issue. For ref: https://github.com/10up/distributor/actions/runs/9710975272/job/26802811307?pr=1002 PR: #1002 |
@peterwilsoncc probably worth reviewing #1002 and #1003 on this feature to determine optimal path forward. |
Is your enhancement related to a problem? Please describe.
When you go to the Pull screen for an Internal/Network Connection, we default to showing content from all supported post types. You can then filter down to just the post type you want (like Posts).
But for External Connections, we default to showing just Posts and there isn't a way to view content across all post types. This is because historically we were requesting content from a post type specific endpoint, so it was impossible to get content across multiple post types. But with the changes introduced in #811, we can now show content from across all supported post types, mirroring how we do this for Internal Connections.
One thing to note here is if you are on an External Connection that has had no content pulled or skipped yet, we utilize the old approach to grabbing content, from a post type specific endpoint and not the new endpoint introduced in #811. So that will need to be addressed here to fully support his new feature.
Code of Conduct
The text was updated successfully, but these errors were encountered: