Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu item ID is not necessarily a number #772

Closed
Knskan3 opened this issue May 20, 2024 · 1 comment · Fixed by #858
Closed

Menu item ID is not necessarily a number #772

Knskan3 opened this issue May 20, 2024 · 1 comment · Fixed by #858

Comments

@Knskan3
Copy link

Knskan3 commented May 20, 2024 •
edited
Loading

headstartwp/packages/core/src/react/hooks/useFetchMenu.ts

Line 21 in 77764a9

const parentId = Number(item.menu_item_parent);

When using polylang, the menu item ID could contain the id-LANG, causing errors during the Number cast.

In example:
Screenshot 2024-05-20 at 16 14 57
@nicholasio
Copy link
Member

Thanks for the bug report

This was referenced Aug 28, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not cast menu items ids to number 10up/headstartwp
2 participants
@Knskan3 @nicholasio